feat(snapshots): write to snapshots during BodyStage

bin/reth/src/commands/db/snapshots/headers.rs

@@ -11,7 +11,6 @@ use reth_primitives::{
 };
 use reth_provider::{
     providers::SnapshotProvider, BlockNumReader, HeaderProvider, ProviderError, ProviderFactory,
-    TransactionsProviderExt,
 };
 use std::{
     path::{Path, PathBuf},
@@ -43,12 +42,8 @@ impl Command {
         let mut row_indexes = block_range.clone().collect::<Vec<_>>();
         let mut rng = rand::thread_rng();
 
-        let tx_range = ProviderFactory::new(open_db_read_only(db_path, log_level)?, chain.clone())
-            .provider()?
-            .transaction_range_by_block_range(block_range.clone())?;
-
         let path: PathBuf = SnapshotSegment::Headers
-            .filename_with_configuration(filters, compression, &block_range, &tx_range)
+            .filename_with_configuration(filters, compression, &block_range)
             .into();
         let provider = SnapshotProvider::new(PathBuf::default())?;
         let jar_provider = provider.get_segment_provider_from_block(

bin/reth/src/commands/db/snapshots/mod.rs

@@ -9,7 +9,7 @@ use reth_primitives::{
     snapshot::{Compression, Filters, InclusionFilter, PerfectHashingFunction, SegmentHeader},
     BlockNumber, ChainSpec, SnapshotSegment,
 };
-use reth_provider::{BlockNumReader, ProviderFactory, TransactionsProviderExt};
+use reth_provider::{BlockNumReader, ProviderFactory};
 use reth_snapshot::{segments as snap_segments, segments::Segment};
 use std::{
     ops::RangeInclusive,
@@ -189,10 +189,7 @@ impl Command {
                         segment.snapshot::<DB>(&provider, &dir, block_range.clone())?;
                     }
 
-                    let tx_range =
-                        provider.transaction_range_by_block_range(block_range.clone())?;
-
-                    Ok(segment.segment().filename(block_range, &tx_range))
+                    Ok(segment.segment().filename(block_range))
                 })
                 .collect::<Result<Vec<_>, eyre::Report>>()?;
 

bin/reth/src/commands/db/snapshots/receipts.rs

@@ -50,7 +50,7 @@ impl Command {
         let mut row_indexes = tx_range.clone().collect::<Vec<_>>();
 
         let path: PathBuf = SnapshotSegment::Receipts
-            .filename_with_configuration(filters, compression, &block_range, &tx_range)
+            .filename_with_configuration(filters, compression, &block_range)
             .into();
 
         let provider = SnapshotProvider::new(PathBuf::default())?;

bin/reth/src/commands/db/snapshots/transactions.rs

@@ -48,7 +48,7 @@ impl Command {
         let mut row_indexes = tx_range.clone().collect::<Vec<_>>();
 
         let path: PathBuf = SnapshotSegment::Transactions
-            .filename_with_configuration(filters, compression, &block_range, &tx_range)
+            .filename_with_configuration(filters, compression, &block_range)
             .into();
         let provider = SnapshotProvider::new(PathBuf::default())?;
         let jar_provider = provider.get_segment_provider_from_block(

crates/interfaces/src/provider.rs

@@ -122,6 +122,9 @@ pub enum ProviderError {
     /// Snapshot file is not found for requested transaction.
     #[error("not able to find {0} snapshot file for transaction id {1}")]
     MissingSnapshotTx(SnapshotSegment, TxNumber),
+    /// Snapshot is finalized and cannot be written to.
+    #[error("not able to write to finalized snapshot {0} (block #{1})")]
+    FinalizedSnapshot(SnapshotSegment, BlockNumber),
     /// Error encountered when the block number conversion from U256 to u64 causes an overflow.
     #[error("failed to convert block number U256 to u64: {0}")]
     BlockNumberOverflow(U256),

crates/primitives/src/snapshot/mod.rs

@@ -4,6 +4,8 @@ mod compression;
 mod filters;
 mod segment;
 
+use std::ops::RangeInclusive;
+
 use alloy_primitives::BlockNumber;
 pub use compression::Compression;
 pub use filters::{Filters, InclusionFilter, PerfectHashingFunction};
@@ -45,3 +47,10 @@ impl HighestSnapshots {
         }
     }
 }
+
+/// Each snapshot has a fixed number of blocks. This gives out the range where the requested block
+/// is positioned. Used for segment filename.
+pub fn find_fixed_range(interval: u64, block: BlockNumber) -> RangeInclusive<BlockNumber> {
+    let start = (block / interval) * interval;
+    start..=start + interval - 1
+}