feat(snapshots): write to snapshots during BodyStage
#5733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b9c51e9.
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
mattsse
requested changes
Jan 18, 2024
| let mut next_tx_num = tx_cursor.last()?.map(|(id, _)| id + 1).unwrap_or_default(); | ||
| let mut next_tx_num = tx_block_cursor.last()?.map(|(id, _)| id + 1).unwrap_or_default(); | ||
|
|
||
| let snapshot_provider = provider.snapshot_provider().expect("should exist"); |
There was a problem hiding this comment.
hmm, I don't really like this panic.
I guess this is an expect because unreachable?
There was a problem hiding this comment.
yeah, stages [should] receive a DatabaseProvider with a SnapshotProvider
shekhirin
force-pushed
the
joshie/tx-snap-sync
branch
from
083ac14
to
dd749fc
Compare
joshieDo
force-pushed
the
joshie/tx-snap-sync
branch
from
16e1a2a
to
ead73cc
Compare
joshieDo
force-pushed
the
joshie/tx-snap-sync
branch
from
ead73cc
to
782f7e3
Compare
shekhirin
approved these changes
Jan 26, 2024
mattsse
approved these changes
Jan 26, 2024
| @@ -53,7 +53,7 @@ impl Command { | |||
| let mut row_indexes = tx_range.clone().collect::<Vec<_>>(); | |||
|
|
|||
| let path: PathBuf = SnapshotSegment::Receipts | |||
| .filename_with_configuration(filters, compression, &block_range, &tx_range) | |||
| .filename_with_configuration(filters, compression, &block_range) | |||
| [self.data_path().into(), self.index_path(), self.offsets_path(), self.config_path()] | ||
| { | ||
| if path.exists() { | ||
| std::fs::remove_file(path)?; |
| path::Path, | ||
| }; | ||
|
|
||
| /// Size of one offset in bytes. | ||
| const OFFSET_SIZE_BYTES: u64 = 8; | ||
|
|
||
| /// Holds a reference or an owned [`NippyJar`]. | ||
| #[derive(Debug)] | ||
| enum CowJar<'a, H: NippyJarHeader = ()> { |
There was a problem hiding this comment.
this is Clone so the Cow prefix isn't accurate. though I'm fine this, because it conveys what does
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: joshieDo <ranriver@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writes
TransactionSignedNoHashto static files instead ofmdbxduringBodyStage.tx_rangefrom filename #5823SegmentHeaderblock range in the*.conffile is the actual block range (eg. the latest one will have less than 500k blocks), while the filename block range is fixed to the 500k interval. This allows for easier file consistency and querying.SnapshotProviderRWused by stages to append data. It can also unwind/truncate data when an inconsistency error occurs (eg. node shuts down after a static file commit, but before the database could commit).