feat: remove tx_range from filename
#5823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
reviewed
Dec 18, 2023
| pub fn tx_range(&self) -> &RangeInclusive<TxNumber> { | ||
| &self.tx_range | ||
| pub fn tx_range(&self) -> Option<RangeInclusive<TxNumber>> { | ||
| self.tx_range.as_ref().map(|range| range.clone()) |
There was a problem hiding this comment.
Suggested change
| self.tx_range.as_ref().map(|range| range.clone()) | |
| self.tx_range.clone() |
| @@ -195,44 +180,63 @@ impl SegmentHeader { | |||
|
|
|||
| /// Returns the first transaction number of the segment. | |||
| pub fn tx_start(&self) -> TxNumber { | |||
| *self.tx_range.start() | |||
| *self.tx_range.as_ref().expect("should exist").start() | |||
There was a problem hiding this comment.
it may not exist for the Headers segment
| @@ -43,7 +45,7 @@ pub struct SnapshotProvider { | |||
| /// segments and ranges. | |||
| map: DashMap<(BlockNumber, SnapshotSegment), LoadedJar>, | |||
| /// Available snapshot transaction ranges on disk indexed by max blocks. | |||
Comment on lines
191
to
197
| .filter_map(|max| { | ||
| if **max >= block { | ||
| return Some(find_fixed_range(BLOCKS_PER_SNAPSHOT, block)) | ||
| } | ||
| None | ||
| }) | ||
| .next() |
shekhirin
force-pushed
the
joshie/rm-tx-range
branch
from
fd310e6
to
fd1c8c1
Compare
shekhirin
force-pushed
the
joshie/rm-tx-range
branch
from
fd1c8c1
to
65551c5
Compare
joshieDo
requested review from
rakita,
onbjerg,
rkrasiuk and
gakonst
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tx_rangefrom filenameSegmentHeaderranges as source of truthfind_fixed_rangewhen dealing with filenames or find out if new insertion is past the expected range