Fix Ingester tests #4249
Merged
Fix Ingester tests #4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gernest
force-pushed
the
fix-ingestion-test
branch
from
429e3b7
to
7a7d849
Compare
Ingester no longer inserts parquet data to `frostdb` the tests were passing by accident (assertions were in the wrong block that was never executed). I needed these tests to be correct and passing because a lot of work has been done on `frostdb` to facilitate automatic record generation. To upgrade to these new improvements. - Both implementation must generate the same output `arrow.Record` I included generated arrows in `testdata` directory for the reason above.
thorfour
force-pushed
the
fix-ingestion-test
branch
from
6bcfd5e
to
48b8e9c
Compare
thorfour
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ingester no longer inserts parquet data to
frostdbthe tests were passing by accident (assertions were in the wrong block that was never executed).I needed these tests to be correct and passing because a lot of work has been done on
frostdbto facilitate automatic record generation. To upgrade to these new improvements.arrow.RecordI included generated arrows in
testdatadirectory for the reason above.