Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ingester tests #4249

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Fix Ingester tests #4249

merged 4 commits into from
Jan 9, 2024

Commits on Jan 9, 2024

  1. Fix Ingester tests

    Ingester no longer inserts parquet data to `frostdb` the tests were passing by
    accident (assertions were in the wrong block that was never executed).
    
    I needed these tests to be correct and passing because a lot of work has been
    done on `frostdb` to facilitate automatic record generation. To upgrade to
    these new improvements.
    
    - Both implementation must generate the same output `arrow.Record`
    
    I included generated arrows in `testdata` directory  for the reason above.
    gernest authored and thorfour committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    81ddb0d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f171f4e View commit details
    Browse the repository at this point in the history
  3. fix lint: remove assert package

    gernest authored and thorfour committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    9033fa8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    48b8e9c View commit details
    Browse the repository at this point in the history