-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of ora spinner fails on Jenkins/CI #1711
Comments
Thanks. I think we should change this line: https://github.com/parcel-bundler/parcel/pull/1472/files#diff-ee6e6eca9dc30e7f279fcadf6f6b9346R129 enabled: this.isTest ? false : undefined This way it will fall back to the |
|
We can probably contribute a fix for that back to ora @icopp |
@DeMoorJasper From their issues it looked like they actively avoided fixing it for some reason, so I would personally be pessimistic there. |
@devongovett I think this would help too? sindresorhus/ora#82 (without having to muck with enabled/disabled opt) lol we're all hitting this same issue. |
Should be fixed in 8670fd6. Released in v1.9.6. |
@gobengo Thanks for making that PR for ora - that should also get merged I hope and fix some other classes of issue. But this should fix CI for now since ora already checks for tty unless we explicitly enable it as we were before. |
Good work everyone! Thanks for the quick fix. |
🐛 bug report
After upgrading to the latest 1.9.5 version, the introduction of
ora
#1472 is producing the following error running on Jenkins or CI:According to
ora
source, whenenabled
is always set, it ignores theprocess.env.CI
var, which can be used to disable the spinner.🤔 Expected Behavior
Running
parcel
should disable the spinner in environments where it is unsupported.😯 Current Behavior
Running on Jenkins fails immediately when attempting to display the
ora
spinner whenclearLine
is unavailable.💁 Possible Solution
Temporary workaround would be to set
export NODE_ENV=test
, to disable the spinner, but this is not ideal since it conflicts with the use of NODE_ENV as production or development. This also breaks with how v1.9.4 worked. Ideally, environment detection for enabling the spinner should happen internally.🔦 Context
Blocked from upgrading to the latest version of Parcel because of this unexpected break.
🌍 Your Environment
The text was updated successfully, but these errors were encountered: