Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor logger improvement and a bugfix #1472

Merged
merged 4 commits into from
Jul 7, 2018
Merged

Conversation

DeMoorJasper
Copy link
Member

@DeMoorJasper DeMoorJasper commented Jun 1, 2018

This PR adds a spinner using ora, this replaces the status code.
As this is already battletested it should fix some issues we've been seeing with status.

This PR also changes error logging to log the message using console.log instead of status

This also fixes a bug in lineCounter, as it wasn't being ansiStripped, which caused incorrect lineCounts (mainly for error Stacks)

2018-06-01 20 10 24

screen shot 2018-06-01 at 20 11 20

Closes #923 Closes #349 Closes #1293

@DeMoorJasper DeMoorJasper changed the title Minor logger improvements Minor logger improvements and a bugfix Jun 1, 2018
@DeMoorJasper DeMoorJasper changed the title Minor logger improvements and a bugfix Minor logger improvement and a bugfix Jun 1, 2018
@devongovett
Copy link
Member

Made a slight refactor to create separate logger.progress and logger.success methods, instead of one logger.status. This should be easier to use since it handles the emoji/spinner for you, and the code is a bit simpler.

@devongovett devongovett merged commit c966120 into master Jul 7, 2018
@devongovett devongovett deleted the feature/logger-improvement branch July 7, 2018 06:57
@sebastian-schmitt
Copy link

sebastian-schmitt commented Jul 11, 2018

it seems as if there is a problem with the parcel-ora-integration when running parcel inside a docker container. This may be related to this and this.

I'm sorry for just commenting here instead of opening a new issue - as soon as I get to a "real" keyboard I will do so.

EDIT: here comes the link to the issue

2zH pushed a commit to 2zH/parcel that referenced this pull request Jul 11, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛IntelliJ terminal output not clearing lines 🐛 Long error messages gets cut off
3 participants