Apply suggestions from rust-clippy

[mischnic]

Fix some warnings produced by running https://github.com/rust-lang/rust-clippy

Make Github hide whitespace changes when viewing the diff

• unnecessary .clone()s
• use if let Foo(y) = x ... instead of match x { Foo(y) => ..., _ => {} }
• merge nested if statements into a single one with the conditionA && conditionB
• remove unnecessary return keywords
• merge nested type checking if possible:

      if let Lit(lit) = &*arg.expr {
        if let ast::Lit::Str(str_) = lit {

can be

      if let Lit(ast::Lit::Str(str_)) = &*arg.expr {

(same for match)

• use .map(|v| something(v)) instead of if let Some(v) = ... { something(v)} else {None}
• use .is_empty() when possible
• .iter().flatten() instead of for n in list { if Some(n) = n { ...
• "Object spreading":

    let mut esconfig = EsConfig::default();
    esconfig.jsx = config.is_jsx;
    esconfig.dynamic_import = true;
    esconfig.export_default_from = true;
    esconfig.export_namespace_from = true;
    esconfig.import_meta = true;
    Syntax::Es(esconfig)

becomes:

    Syntax::Es(EsConfig {
      jsx: config.is_jsx,
      dynamic_import: true,
      export_default_from: true,
      export_namespace_from: true,
      import_meta: true,
      ..Default::default()
    })

• .or_insert(something()) should rather be .or_insert_with(|| something()) so that the function is only called when needed

[height]

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

[parcel-benchmark]

Benchmark Results

Kitchen Sink ✅

Timings

Description	Time	Difference
Cold	2.18s	+35.00ms
Cached	322.00ms	-17.00ms 🚀

Cold Bundles

Bundle	Size	Difference	Time	Difference
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	657.00ms	+571.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	658.00ms	+571.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp	102.94kb	+0.00b	658.00ms	+571.00ms ⚠️

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description	Time	Difference
Cold	11.07s	-61.00ms
Cached	514.00ms	+35.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description	Time	Difference
Cold	1.25m	-219.00ms
Cached	1.84s	+26.00ms

Cold Bundles

Bundle	Size	Difference	Time	Difference
dist/index.4408191d.js	1.77mb	+6.00b ⚠️	21.74s	-38.00ms
dist/index.92823b4c.js	694.60kb	-11.00b 🚀	57.93s	+106.00ms
dist/Modal.62f95654.js	45.30kb	+15.00b ⚠️	57.28s	-6.00ms

Cached Bundles

Bundle	Size	Difference	Time	Difference
dist/index.8abd161c.js	694.59kb	-19.00b 🚀	58.28s	+241.00ms
dist/Modal.342d8783.js	45.30kb	+15.00b ⚠️	57.67s	+115.00ms

Three.js ✅

Timings

Description	Time	Difference
Cold	7.97s	-5.00ms
Cached	415.00ms	-26.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

[devongovett]

TIL 😲