Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stream-browserify for polyfilling instead #6863

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Use stream-browserify for polyfilling instead #6863

merged 1 commit into from
Sep 2, 2021

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Sep 1, 2021

Closes #6846

Partially reverts #4225 🙈

@height
Copy link

height bot commented Sep 1, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.92s -7.00ms
Cached 319.00ms +2.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 548.00ms +469.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 549.00ms +469.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 549.00ms +469.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 10.13s +20.00ms
Cached 487.00ms +2.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.11m +92.00ms
Cached 1.74s -20.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.1adebaca.js 1.77mb -2.00b 🚀 19.06s +150.00ms
dist/index.cfa9ed7e.js 694.59kb +4.00b ⚠️ 50.94s -155.00ms
dist/editorView.32f0bc5b.js 594.90kb +0.00b 50.89s +12.87s ⚠️
dist/popup.b9bfc626.js 209.65kb +0.00b 50.89s +12.87s ⚠️
dist/EmojiPickerComponent.8a8cd6b4.js 146.66kb +0.00b 20.55s -11.09s 🚀
dist/Toolbar.7b43353f.js 107.22kb +0.00b 50.89s +12.87s ⚠️
dist/Modal.0f1a1059.js 45.31kb +0.00b 50.89s +12.87s ⚠️
dist/esm.1d6517f3.js 33.13kb +0.00b 20.55s -11.09s 🚀
dist/DatePicker.b9b943f1.js 22.96kb +0.00b 20.55s -11.09s 🚀
dist/ui.40e4b6ba.js 14.93kb +0.00b 50.89s +12.87s ⚠️
dist/smartMediaEditor.94bf00c1.js 13.24kb +0.00b 50.89s +12.87s ⚠️
dist/dropzone.0d183115.js 12.13kb +0.00b 50.89s +12.87s ⚠️
dist/EmojiPickerComponent.55e0a64c.js 3.71kb +0.00b 50.89s +12.87s ⚠️
dist/dropzone.a10cce43.js 3.28kb +0.00b 50.89s +12.87s ⚠️
dist/clipboard.969d5ad7.js 2.92kb +0.00b 50.89s +12.87s ⚠️
dist/ResourcedEmojiComponent.78f6ddfc.js 2.10kb +0.00b 50.89s +12.87s ⚠️
dist/feedback.e18b45f0.js 1.75kb +0.00b 20.54s -11.10s 🚀
dist/browser.17513657.js 1.68kb +0.00b 50.89s +12.87s ⚠️
dist/workerHasher.567cfc57.js 1.62kb +0.00b 20.55s -11.10s 🚀
dist/heading6.b3b946d1.js 1.49kb +0.00b 20.54s -11.10s 🚀
dist/heading5.e617db66.js 1.37kb +0.00b 20.54s -11.10s 🚀
dist/expand.1f17de7f.js 1.27kb +0.00b 20.55s -11.09s 🚀
dist/media-card-analytics-error-boundary.75fac461.js 1.10kb +0.00b 50.89s +12.87s ⚠️
dist/media-picker-analytics-error-boundary.1602c912.js 949.00b +0.00b 50.89s +12.87s ⚠️
dist/simpleHasher.2a6e12b6.js 626.00b +0.00b 50.89s +12.87s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/index.0b9cdb0c.js 1.77mb -2.00b 🚀 19.45s +451.00ms
dist/index.9deb2a04.js 694.60kb -15.00b 🚀 51.17s +412.00ms

Three.js ✅

Timings

Description Time Difference
Cold 7.07s +11.00ms
Cached 406.00ms -3.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 0b823c2 into v2 Sep 2, 2021
@devongovett devongovett deleted the change-stream-polyfill branch September 2, 2021 04:04
lettertwo added a commit that referenced this pull request Sep 10, 2021
@lettertwo
Merge branch 'v2' into lettertwo/buffer-backed-graph
01ae61b 
* v2: (69 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 10, 2021
@lettertwo
Merge branch 'v2' into bdo/number-edgetypes
fb3d269 
* v2: (38 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 11, 2021
@lettertwo
Merge branch 'bdo/number-edgetypes' into lettertwo/buffer-backed-graph
f72e689 
* bdo/number-edgetypes: (70 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
@lettertwo
Merge branch 'v2' into bdo/number-edgetypes
a97bcc1 
* v2: (38 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
@lettertwo
Merge branch 'bdo/number-edgetypes' into lettertwo/buffer-backed-graph
7e72653 
* bdo/number-edgetypes: (70 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
@lettertwo
Merge branch 'v2' into bdo/number-edgetypes
c0b7651 
* v2: (42 commits)
  Remove dead link to docs in diagnostic (#6913)
  Fix engines.parcel in SVG packager (#6911)
  Use imported Readable flow type instead of global (#6910)
  Use non-deprecated SVGO options in HTMLNanoOptimizer (#6785)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
@lettertwo
Merge branch 'v2' into bdo/number-edgetypes
0b0a475 
* v2: (42 commits)
  Remove dead link to docs in diagnostic (#6913)
  Fix engines.parcel in SVG packager (#6911)
  Use imported Readable flow type instead of global (#6910)
  Use non-deprecated SVGO options in HTMLNanoOptimizer (#6785)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
@lettertwo
Merge branch 'bdo/number-edgetypes' into lettertwo/buffer-backed-graph
f964457 
* bdo/number-edgetypes: (74 commits)
  Remove dead link to docs in diagnostic (#6913)
  Fix engines.parcel in SVG packager (#6911)
  Use imported Readable flow type instead of global (#6910)
  Use non-deprecated SVGO options in HTMLNanoOptimizer (#6785)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stream polyfill issue: "Error: The _read() method is not implemented"
3 participants
@mischnic @parcel-benchmark @devongovett