This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 378
Companion for primitives consolidation into v2 #1071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview
B0-silent
Changes should not be mentioned in any release notes
labels
Mar 7, 2022
ordian
approved these changes
Mar 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if Cargo.lock
changes will generate merge conflicts. Looks good otherwise.
bkchr
approved these changes
Mar 10, 2022
bot merge |
Waiting for commit status. |
bot merge |
Waiting for commit status. |
10 tasks
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
May 17, 2022
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
May 17, 2022
This reverts commit f772a45.
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
May 18, 2022
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
May 18, 2022
This reverts commit f772a45.
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
May 31, 2022
2 tasks
10 tasks
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all references to polkadot_primitives::v1 and v0 (there were a handful of these).
This is a companion for paritytech/polkadot#5037