Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Finish migration to v2 primitives #5037

Merged
merged 9 commits into from
Mar 9, 2022
Merged

Finish migration to v2 primitives #5037

merged 9 commits into from
Mar 9, 2022

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Mar 7, 2022

Closes #4803
Closes #4802

This removes v0 and v1 primitives, migrating everything to v2 instead. This also adds a RuntimeApiRequest::Version (currently, the runtime API subsystem handles versions internally, but it'd be better for that to be handled at the subsystem level after doing high-level version checks).

cumulus companion: paritytech/cumulus#1071

@rphmeier rphmeier added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Mar 7, 2022
@rphmeier
Copy link
Contributor Author

rphmeier commented Mar 7, 2022

I've fully removed v0 and will remove v1 next (this one will get a bit tedious :) )

@rphmeier rphmeier marked this pull request as ready for review March 7, 2022 06:48
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Mar 7, 2022
primitives/src/v2/mod.rs Outdated Show resolved Hide resolved
@rphmeier
Copy link
Contributor Author

rphmeier commented Mar 7, 2022

@ordian At some point we should be able to remove the storage migration and the #[changed_in(2)] version of the runtime API.

@rphmeier
Copy link
Contributor Author

rphmeier commented Mar 7, 2022

@sandreim is going to test on Versi & ZombieNet, and then we can merge 🎉

@sandreim
Copy link
Contributor

sandreim commented Mar 9, 2022

Tested on Versi and ZombieNet and did not see any issues with parachain block production. I have observed some errors and warnings:

  • offchain-worker txpool: (offchain call) Error submitting a transaction to the pool: Transaction pool error
  • parachain::candidate-backing: Mpsc background validation mpsc died during validation- leaf no longer active? error=SendError { kind: Disconnected }

@rphmeier
Copy link
Contributor Author

rphmeier commented Mar 9, 2022

Neither of those seem related. Thank you for testing @sandreim

@rphmeier rphmeier merged commit 88d66ac into master Mar 9, 2022
@rphmeier rphmeier deleted the rh-finish-v2-primitives branch March 9, 2022 20:01
@ggwpez
Copy link
Member

ggwpez commented Mar 9, 2022

I think the cumulus companion did not merge, so cumulus does currently not build with polkadot master.
@rphmeier

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete migration to v2 primitives & parachain-host Remove v0 primitives
4 participants