Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Transaction payment runtime apis: query call info and fee details #1535

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Transaction payment runtime apis: query call info and fee details #1535

merged 2 commits into from
Aug 18, 2022

Conversation

muharem
Copy link
Contributor

@muharem muharem commented Aug 10, 2022

Fixes paritytech/substrate#11665

New runtime api introduced in PR paritytech/substrate#11819

@paritytech-ci paritytech-ci requested review from a team August 10, 2022 12:55
muharem
muharem commented Aug 10, 2022
View reviewed changes
Cargo.lock Outdated
@@ -451,7 +451,7 @@ dependencies = [
[[package]]
name = "beefy-gadget"
version = "4.0.0-dev"
source = "git+https://github.com/paritytech/substrate?branch=master#fece0657f20e15df94be5833b164dfacd44823eb"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

result of cargo update -p pallet-transaction-payment-rpc-runtime-api

@muharem muharem added A0-pleasereview C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Aug 10, 2022
@muharem muharem requested review from athei and bkchr August 10, 2022 12:57
@muharem muharem added C1-low 📌 and removed C1-low PR touches the given topic and has a low impact on builders. labels Aug 10, 2022
@paritytech-ci paritytech-ci requested a review from a team August 11, 2022 15:39
@muharem muharem requested review from dvdplm and kianenigma August 11, 2022 15:41
@muharem
Copy link
Contributor Author

muharem commented Aug 11, 2022

continuous-integration/gitlab-check-runtime check fail can be ignored, explained - https://github.com/paritytech/ci_cd/issues/538

@the-right-joyce the-right-joyce added A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. and removed A0-pleasereview labels Aug 12, 2022
@athei athei added the T2-API This PR/Issue is related to APIs. label Aug 18, 2022
ggwpez
ggwpez approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any RPC integration tests which query a node, maybe we should add that in the future.

@muharem
Copy link
Contributor Author

muharem commented Aug 18, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 1680ae3 into master Aug 18, 2022
@paritytech-processbot paritytech-processbot bot deleted the muharem-transaction-payment-runtime-api-query-call-info-and-fee-detail branch August 18, 2022 11:01
@librelois librelois mentioned this pull request Sep 15, 2022
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

@athei athei athei approved these changes

@dvdplm dvdplm dvdplm approved these changes

@kianenigma kianenigma Awaiting requested review from kianenigma

@eskimor eskimor Awaiting requested review from eskimor

@shawntabrizi shawntabrizi Awaiting requested review from shawntabrizi

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. T2-API This PR/Issue is related to APIs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make get_dispatch_info and weight_to_fee Available via state_call
6 participants
@muharem @dvdplm @athei @bkchr @ggwpez @the-right-joyce