Transaction payment runtime api: query call info and fee details #11819

muharem · 2022-07-12T10:18:02Z

Related #11665

New rpc and runtime api calls to query weights and fee for Call.

Use case:

BuyExecution for XCM Transact operation, to execute Call.

Requirements:

provide runtime api calls to utilize api.rpc.state.call for light clients (not only RPC calls)
no new custom RPCs

Useful links:

Substrate Recepis: Runtime APIs
Substrate Recepis: Custom RPCs
RPC state call

frame/transaction-payment/rpc/runtime-api/src/lib.rs

frame/transaction-payment/src/lib.rs

frame/transaction-payment/rpc/runtime-api/src/lib.rs

frame/transaction-payment/rpc/src/lib.rs

frame/transaction-payment/rpc/runtime-api/src/lib.rs

frame/transaction-payment/src/lib.rs

…e_details

frame/transaction-payment/rpc/runtime-api/src/lib.rs

athei

You should create a follow up issue with https://github.com/polkadot-js/api so that the new API is supported there.

athei · 2022-08-08T16:48:29Z

The problem here being that a runtime api should always use a "stable" api.

Why is this a problem?

bkchr · 2022-08-08T18:57:56Z

The problem here being that a runtime api should always use a "stable" api.

Why is this a problem?

I know that I'm a little bit pedantic here.

athei · 2022-08-09T09:02:49Z

The problem here being that a runtime api should always use a "stable" api.

Why is this a problem?

I know that I'm a little bit pedantic here.

It was an honest question. I want to know why you think it is better to fail later within the runtime. I don't understand why that changes anything compatibility wise. Clients still need to encode it according to whatever the runtime expects.

I think it is better to have the type defined on the runtime API so it is obvious for clients what the signature of the API is. Otherwise they need to look into the actual code that decodes it later to know what is expected. Additionally, the plan is to expose runtime APIs through metadata just like extrinsics which would be totally pointless if all types are opaque.

bkchr · 2022-08-09T09:47:57Z

Hmm yeah good point and sorry for my useless answer.

Yeah, maybe we should treat them as some sort of special runtime api. In the future we should probably provide some way to expose these apis more easily from the runtime. Aka not requiring first to declare the api somewhere else.

athei · 2022-08-10T09:00:40Z

So we go back to declaring the proper type in the API? I am not sure what the implications are. i.e where does the decoding failure happen.

muharem · 2022-08-10T09:25:07Z

@bkchr @athei using Call type now for api.

@athei decoding failure is upstream, somewhere within state_call.
I also tested the runtime api with Call type, by calling state_call and passing string of bytes from (Call, len).encode(). It works.

muharem · 2022-08-10T09:49:38Z

frame/transaction-payment/rpc/runtime-api/src/lib.rs

+ Balance: Codec + MaybeDisplay,
+ Call: Codec,
+ {
+ /// Query information of a dispatch class, weight, and fee of a given encoded `Call`.


removed panic, since the implementation itself is not supposed to panic, only upstream state_call

muharem · 2022-08-10T10:36:08Z

bot merge

…itytech#11819) * Transaction payment RPC calls: query call info * transaction payment pallet - runtime api - add query_call info and fee_details * remove unused deps * separate call runtime api * undo fmt for unchanged code * system config call bounded to GetDispatchInfo, drop Call generic for query call info/fee * impl GetDispatchInfo for Extrinsics within runtime test-utils * introduced runtime api methods accept encoded Call instead of Call type * replace Bytes by Vec, docs for for new api, drop len argument, drop GetDispatchInfo bound from system_Config::Call * clean up toml and extra impl for dropped bound * panic if Call can not be decoded * revert to 6d0ca79 * fmt and docs * rustfmt

Transaction payment RPC calls: query call info

ed95f05

muharem added A3-in_progress Pull request is in progress. No review needed at this stage. B3-apinoteworthy C3-medium PR touches the given topic and has a medium impact on builders. labels Jul 12, 2022

github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Jul 12, 2022

muharem commented Jul 12, 2022

View reviewed changes

frame/transaction-payment/rpc/runtime-api/src/lib.rs Outdated Show resolved Hide resolved

frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

frame/transaction-payment/rpc/runtime-api/src/lib.rs Outdated Show resolved Hide resolved

muharem changed the title ~~Transaction payment RPC calls: query call info~~ [inprocess] Transaction payment RPC calls: query call info Jul 12, 2022

muharem commented Jul 12, 2022

View reviewed changes

frame/transaction-payment/rpc/runtime-api/src/lib.rs Outdated Show resolved Hide resolved

frame/transaction-payment/rpc/src/lib.rs Outdated Show resolved Hide resolved

athei reviewed Jul 12, 2022

View reviewed changes

muharem added 2 commits July 16, 2022 20:59

transaction payment pallet - runtime api - add query_call info and fe…

535b925

…e_details

remove unused deps

8e707c3

muharem added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Jul 16, 2022

muharem added 2 commits July 17, 2022 21:04

separate call runtime api

083fa77

undo fmt for unchanged code

a597aea

muharem commented Jul 17, 2022

View reviewed changes

frame/transaction-payment/rpc/runtime-api/src/lib.rs Show resolved Hide resolved

athei approved these changes Jul 18, 2022

View reviewed changes

muharem added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Jul 18, 2022

muharem changed the title ~~[inprocess] Transaction payment RPC calls: query call info~~ Transaction payment RPC calls: query call info Jul 18, 2022

This was referenced Jul 19, 2022

Transfer with Transact Design Discussion open-web3-stack/open-runtime-module-library#766

Open

transfer_with_transact impl - iteration 2 Manta-Network/open-runtime-module-library#6

Draft

muharem mentioned this pull request Jul 20, 2022

Support new runtime_api/rpc calls query_call_info and query_call_fee_details polkadot-js/api#5092

Closed

4 tasks

muharem requested review from bkchr, gilescope and shawntabrizi July 21, 2022 13:11

muharem removed the B5-clientnoteworthy label Jul 22, 2022

muharem added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Aug 10, 2022

revert to 6d0ca79

91dfcf2

muharem added 2 commits August 10, 2022 11:15

fmt and docs

273cf09

rustfmt

f8efc1c

muharem added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Aug 10, 2022

muharem requested a review from bkchr August 10, 2022 09:21

athei approved these changes Aug 10, 2022

View reviewed changes

muharem commented Aug 10, 2022

View reviewed changes

bkchr approved these changes Aug 10, 2022

View reviewed changes

paritytech-processbot bot merged commit edeba3f into master Aug 10, 2022

paritytech-processbot bot deleted the transaction-payment-rpc-calls-query-call-info branch August 10, 2022 10:36

This was referenced Aug 10, 2022

Transaction payment runtime apis: query call info and fee details paritytech/polkadot#5871

Merged

Transaction payment runtime apis: query call info and fee details paritytech/cumulus#1535

Merged

athei mentioned this pull request Aug 12, 2022

Various improvements + Sync with substrate paritytech/substrate-contracts-node#144

Merged

Garandor mentioned this pull request Aug 16, 2022

Expose new Transaction payment Runtime API Manta-Network/Manta#756

Closed

wischli mentioned this pull request Sep 2, 2022

feat: upgrade to Polkadot v0.9.28 KILTprotocol/kilt-node#402

Merged

6 tasks

librelois mentioned this pull request Sep 15, 2022

Update substrate/polkadot/cumulus from v0.9.26 to v0.9.29 moonbeam-foundation/moonbeam#1814

Closed

2 tasks

xcaptain mentioned this pull request Oct 11, 2022

optimize code for upgrade deeper-chain/deeper-chain#342

Merged

Dengjianping mentioned this pull request Jan 16, 2023

Bump Polkadot Dependencies to v0.9.28 Manta-Network/Manta#967

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transaction payment runtime api: query call info and fee details #11819

Transaction payment runtime api: query call info and fee details #11819

muharem commented Jul 12, 2022 •

edited

Loading

athei left a comment •

edited

Loading

athei commented Aug 8, 2022

bkchr commented Aug 8, 2022

athei commented Aug 9, 2022

bkchr commented Aug 9, 2022

athei commented Aug 10, 2022

muharem commented Aug 10, 2022

muharem Aug 10, 2022

muharem commented Aug 10, 2022

Transaction payment runtime api: query call info and fee details #11819

Transaction payment runtime api: query call info and fee details #11819

Conversation

muharem commented Jul 12, 2022 • edited Loading

athei left a comment • edited Loading

Choose a reason for hiding this comment

athei commented Aug 8, 2022

bkchr commented Aug 8, 2022

athei commented Aug 9, 2022

bkchr commented Aug 9, 2022

athei commented Aug 10, 2022

muharem commented Aug 10, 2022

muharem Aug 10, 2022

Choose a reason for hiding this comment

muharem commented Aug 10, 2022

muharem commented Jul 12, 2022 •

edited

Loading

athei left a comment •

edited

Loading