Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Transaction payment runtime apis: query call info and fee details #5871

Merged

Conversation

muharem
Copy link
Contributor

@muharem muharem commented Aug 10, 2022

Fixes paritytech/substrate#11665

New runtime api introduced in PR paritytech/substrate#11819

@muharem muharem added A0-please_review Pull request needs code review. B1-releasenotes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Aug 10, 2022
@paritytech-ci paritytech-ci requested review from a team August 10, 2022 12:08
Cargo.lock Outdated
@@ -423,7 +423,7 @@ dependencies = [
[[package]]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

result of cargo update -p pallet-transaction-payment-rpc-runtime-api

@muharem muharem requested review from athei and bkchr and removed request for athei and bkchr August 10, 2022 12:09
@muharem muharem added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Aug 10, 2022
@muharem muharem requested review from athei and bkchr August 10, 2022 12:52
@muharem muharem added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Aug 10, 2022
@muharem
Copy link
Contributor Author

muharem commented Aug 10, 2022

continuous-integration/gitlab-check-runtime check fail can be ignored, explained - https://github.com/paritytech/ci_cd/issues/538

@paritytech-ci paritytech-ci requested a review from a team August 10, 2022 20:18
@muharem muharem requested review from kianenigma and dvdplm August 11, 2022 15:42
@muharem muharem added D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. and removed D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Aug 12, 2022
@muharem muharem requested a review from eskimor August 12, 2022 15:04
@bkchr
Copy link
Member

bkchr commented Aug 15, 2022

@muharem you now need to merge master and then this is mergable.

@muharem muharem removed the request for review from dvdplm August 15, 2022 11:10
@muharem muharem removed the request for review from eskimor August 15, 2022 11:10
@muharem
Copy link
Contributor Author

muharem commented Aug 15, 2022

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for 09c24fd

@muharem muharem merged commit b8c957d into master Aug 15, 2022
@muharem muharem deleted the transaction-payment-runtime-api-query-call-info-and-fee-details branch August 15, 2022 12:39
ordian added a commit that referenced this pull request Aug 15, 2022
* master:
  Transaction payment runtime apis: query call info and fee details (#5871)
  [ci] Improve cancel-pipeline job (#5874)
  Bump wasmtime from 0.38.1 to 0.38.3 (#5802)
  Incorporate changes from substrate PR #11908 (#5815)
  Add nomination pools to Polkadot runtime (#5582)
  Change request-response protocol names to include genesis hash & fork id (#5870)
  [ci] Run check-runtime only for PRs (#5858)
  Bump tokio from 1.18.2 to 1.19.2 (#5678)
  Zombienet: test disputes with malus garbage candidates (#5857)
  add unit tests to run runtime migrations (#5865)
  Trivial networking changes for Substrate PR #11940 (#5841)
  Renaming CLI prunning and keep-blocks flags (#5863)
  Update yamux to fix a potential crash (#5861)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make get_dispatch_info and weight_to_fee Available via state_call
4 participants