This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
add unit tests to run runtime migrations #5865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
added
A0-please_review
coderobe
approved these changes
Aug 8, 2022
bkchr
approved these changes
Aug 8, 2022
runtime/westend/src/lib.rs
Outdated
| .to_string() | ||
| .into(); | ||
| let maybe_state_snapshot: Option<SnapshotConfig> = | ||
| std::option_env!("SNAP").map(|s| s.to_string().into()); |
There was a problem hiding this comment.
Why not parse the env variable at runtime? Why at compile time?
There was a problem hiding this comment.
no particular preference to be honest, I supposedly had the syntax for this on the top of my head 🤷
There was a problem hiding this comment.
I think its better to do at runtime, we had CI problems in the past where the CI did not provide the ENV variables.
Co-authored-by: Mara Robin B. <mara@broda.me>
ggwpez
approved these changes
Aug 9, 2022
I think this is fine for PR testing, but before release we should still execute stuff with wasm |
kianenigma
commented
Aug 9, 2022
shawntabrizi
approved these changes
Aug 10, 2022
|
bot merge |
ordian
added a commit
that referenced
this pull request
Aug 15, 2022
* master: Transaction payment runtime apis: query call info and fee details (#5871) [ci] Improve cancel-pipeline job (#5874) Bump wasmtime from 0.38.1 to 0.38.3 (#5802) Incorporate changes from substrate PR #11908 (#5815) Add nomination pools to Polkadot runtime (#5582) Change request-response protocol names to include genesis hash & fork id (#5870) [ci] Run check-runtime only for PRs (#5858) Bump tokio from 1.18.2 to 1.19.2 (#5678) Zombienet: test disputes with malus garbage candidates (#5857) add unit tests to run runtime migrations (#5865) Trivial networking changes for Substrate PR #11940 (#5841) Renaming CLI prunning and keep-blocks flags (#5863) Update yamux to fix a potential crash (#5861)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not replace the try-runtime testing in release process with this, as this is all executing in native and is not realistic. Nonetheless, this can now be toyed with as simple as: