Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Collator set refactor #2144

Closed
wants to merge 142 commits into from
Closed

Collator set refactor #2144

wants to merge 142 commits into from

Conversation

vieira-giulia
Copy link

@vieira-giulia vieira-giulia commented Jan 25, 2023 •
edited
Loading

Functions added:

  • add_invulnerable

  • remove_invulnerable

  • sort invulnerables in set_invulnerables

  • Tests

  • Benchmarking

Weights are still arbitrary values

Giulia Vieira and others added 30 commits December 2, 2022 16:48
first changes: new functions with tests
361e0e9
Merge remote-tracking branch 'origin/master' into collator-set-refactor
605b3f5
changing functions to match invulnerables storage types
00bb9f4
fix typo
263f050
change try get
2c1a139
commenting all to debug
68e50c7
changing way to access storage, using try mutate
a9ff708
@bkchr @vieira-giulia
Provisioner polkadot companion (#1940)
4cfa38d 
* Provisioner companion changes

* update substrate commit hash

* Update Substrate & Polkadot

Co-authored-by: Bastian Köcher <info@kchr.de>
@dependabot @vieira-giulia
Bump environmental from 1.1.3 to 1.1.4 (#1933)
c482bdb 
Bumps environmental from 1.1.3 to 1.1.4.

---
updated-dependencies:
- dependency-name: environmental
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @vieira-giulia
Bump syn from 1.0.104 to 1.0.105 (#1936)
8db69a8 
Bumps [syn](https://github.com/dtolnay/syn) from 1.0.104 to 1.0.105.
- [Release notes](https://github.com/dtolnay/syn/releases)
- [Commits](dtolnay/syn@1.0.104...1.0.105)

---
updated-dependencies:
- dependency-name: syn
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dmitry-markin @vieira-giulia
Upgrade tokio to 1.22.0 and replace async-std with tokio (#1917)
04e8a9e 
* Make tokio executor mandatory

* kick CI

* Update Cargo.lock
@PierreBesson @vieira-giulia
add collectives-polkadot final raw chainspec (#1914)
7e33785
@joao-paulo-parity @vieira-giulia
Companion of Substrate PR 12837 (#1944)
037dae3 
* remove reference to remote-externalities

* update reference to remote-externalities

* s/remote-ext/frame-remote-externalities

* copy the fix from 747400a

* update cargo.lock
@dependabot @vieira-giulia
Bump serde from 1.0.148 to 1.0.149 (#1948)
704b334 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.148 to 1.0.149.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.148...v1.0.149)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mrcnski @vieira-giulia
Remove parity-util-mem (#1958)
17e4d5c 
Fully removes the `parity-util-mem` dependency. This just required upgrading to the latest versions
of the polkadot crates.
@bkchr @vieira-giulia
dependabot: Ignore rococo deps (#1963)
170491f
@dependabot @vieira-giulia
Bump ruby/setup-ruby from 1.120.1 to 1.127.0 (#1951)
9f092ca 
Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.120.1 to 1.127.0.
- [Release notes](https://github.com/ruby/setup-ruby/releases)
- [Commits](ruby/setup-ruby@f2c070b...ee21135)

---
updated-dependencies:
- dependency-name: ruby/setup-ruby
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@EgorPopelyaev @vieira-giulia
add collective runtime upgrade to the checklist (#1966)
699fa2b
@pepoviola @vieira-giulia
zombienet, store node's logs as artifacts (#1969)
69495db
@gilescope @EgorPopelyaev @vieira-giulia
Backport collective weights from v9330 to master (#1959)
5d31af8 
* [benchmarks] pr with weights (#1945)

Co-authored-by: paritytech-ci <paritytech-ci@parity.io>

* Use master for some methods

Co-authored-by: Egor_P <egor@parity.io>
Co-authored-by: paritytech-ci <paritytech-ci@parity.io>
@EgorPopelyaev @vieira-giulia
[Backport] version bumps from 9330 (#1956)
48471f6 
* Bump crate versions

* Bump spec_version to 9330

* bump rococo and penpal spec_version (#1926)

* bump txn versions (#1941)

* bump txn versions

* bump rococo txn version

* bump bridge-hub-kusama spec_version
@alvicsam @vieira-giulia
[ci] new ci runners (#1967)
7dff97a 
* [DNM] test ci runners

* restart pipeline

* switch to c2 runners

* restart pipeline

* change runner tag
@gilescope @EgorPopelyaev @vieira-giulia
[benchmarks] pr with weights (#1946) (#1971)
8236d6c 
Co-authored-by: paritytech-ci <paritytech-ci@parity.io>

Co-authored-by: Egor_P <egor@parity.io>
Co-authored-by: paritytech-ci <paritytech-ci@parity.io>
@KiChjang @vieira-giulia
Companion for paritytech/substrate#12868 (#1970)
6c8bd74 
* Replace WEIGHT_PER_* with WEIGHT_REF_TIME_PER_*

* Fixes

* Fixes

* update lockfile for {"substrate", "polkadot"}

Co-authored-by: parity-processbot <>
@muharem @vieira-giulia
Collectives runtime: add query call info api (#1976)
6c74fcc
@altonen @vieira-giulia
Companion for paritytech/substrate#12764 (#1930)
7250635 
* Companion for paritytech/substrate#12764

* Remove `async-trait`

* Fix trait

* update lockfile for {"substrate", "polkadot"}

Co-authored-by: parity-processbot <>
@chevdor @alvicsam
@the-right-joyce @vieira-giulia
Replace the label checks using bash script by ruled-labels (#1576)
21f2c54 
* Add rules and specs

* add labels

* Add new checks

* Fix criticality check

* Use the new rule filter introduced in ruled-labels v0.3.0 to better target tests

* Add workflow to tests label rules

* Fix trigger

* Add new GH Workflow

* Don't swallow failures but allow them

* Fix new script

* Simplify check

* Fix Workflow

* Remove dup var

* Fix vars

* Move pull image to separate step

* Remove continue on error

* Show input list of labels

* Fix check-labels workflow

* Remove Docker -it flags

* Prevent shell from splitting on spaces

* Fix rules path

* Comment out rules related to labels not present in the repo

* Fix tests

* Fix labels specs and tests

* fix test

* new label description and rules

* fix tests

* use ruled_labels as crate

* fix toolchain

* fix component

* move from docker to crate

* fix test

* fail without labels

* add cache

* fix check no labels

* add D-labels check

* fix emtpy label check

* try docker

* fix specs

* test D label

* revert Cargo.toml

* use tags for ruled_labels

* fix rules

* test D label

* fix tags

* remove changes

* add PR tag to single criticality rule

* remove old line

* test ruled_labels test

* disable Check label Rules

* fix GHA name

* fix tests

* rename files, upd ruled_labels 0.3.2

Co-authored-by: alvicsam <alvicsam@gmail.com>
Co-authored-by: parity-processbot <>
Co-authored-by: Joyce Siqueira <joycesiqueira@Joyces-MacBook-Pro.local>
Co-authored-by: joyce <joyce@parity.io>
Co-authored-by: Joyce Siqueira <98593770+the-right-joyce@users.noreply.github.com>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
@the-right-joyce @vieira-giulia
Description for new cumulus labels (#1879)
c85f97f 
* Add files via upload

Documentation for new labels

* Update documentation.md
@niklasad1 @vieira-giulia
companion for #12663 jsonrpsee v0.16 (#1905)
e8692a3 
* companion for #12663 jsonrpsee v0.16.1

* update deps

* update rpc client params

* update substrate and polkadot
@dependabot @vieira-giulia
Bump tokio from 1.22.0 to 1.23.0 (#1952)
7946cf6 
Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.22.0 to 1.23.0.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-1.22.0...tokio-1.23.0)

---
updated-dependencies:
- dependency-name: tokio
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@command-bot
Copy link

command-bot bot commented Mar 13, 2023

@vieira-giulia Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet statemint asset pallet_collator_selection has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2516921 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2516921/artifacts/download.

@vieira-giulia
Copy link
Author

bot bench $ pallet statemint asset pallet_collator_selection

@command-bot
Copy link

command-bot bot commented Mar 31, 2023 •
edited
Loading

@vieira-giulia https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2623660 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet statemint asset pallet_collator_selection. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 27-dda748b6-afae-4996-8f8d-f78da222a854 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Mar 31, 2023

@vieira-giulia Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet statemint asset pallet_collator_selection has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2623660 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2623660/artifacts/download.

@vieira-giulia
Copy link
Author

bot bench $ pallet statemint asset pallet_collator_selection

@command-bot
Copy link

command-bot bot commented Apr 12, 2023 •
edited
Loading

@vieira-giulia https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2669563 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet statemint asset pallet_collator_selection. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-7e4e0dbf-39a3-4dc8-9772-dae0bd253dae to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Apr 12, 2023

@vieira-giulia Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet statemint asset pallet_collator_selection has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2669563 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2669563/artifacts/download.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2757349

@cla-bot-2021
Copy link

cla-bot-2021 bot commented May 18, 2023

User @vieira-giulia, please sign the CLA here.

@joepetrowski
Copy link
Contributor

Will update

@joepetrowski joepetrowski deleted the collator-set-refactor branch May 18, 2023 17:26
@joepetrowski joepetrowski mentioned this pull request May 18, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xlc xlc xlc left review comments

@gilescope gilescope Awaiting requested review from gilescope

@kianenigma kianenigma Awaiting requested review from kianenigma

@joepetrowski joepetrowski Awaiting requested review from joepetrowski

Assignees
No one assigned
Labels
B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. T0-node This PR/Issue is related to the topic “node”.
Projects
Security Audit (PRs) - SRLabs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.