Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add Ability to Add/Remove Invulnerable Collators #2596

Merged
merged 23 commits into from
May 29, 2023
Merged

Add Ability to Add/Remove Invulnerable Collators #2596

merged 23 commits into from
May 29, 2023

Conversation

joepetrowski
Copy link
Contributor

@joepetrowski joepetrowski commented May 18, 2023 •
edited
Loading

First step in a larger improvement, allowing the ability to add or remove individual collators to/from the Invulnerables set. Individuals can use this to propose themselves as invulnerables without needing to propose an entire set.

This was discussed in https://forum.polkadot.network/t/economic-model-for-system-para-collators/1010

A follow up will be to address paritytech/polkadot-sdk#106

Supersedes #2144

@joepetrowski joepetrowski added A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. T1-runtime This PR/Issue is related to the topic “runtime”. labels May 18, 2023
@paritytech-ci paritytech-ci requested review from a team May 18, 2023 17:44
Ank4n
Ank4n reviewed May 21, 2023
View reviewed changes
pallets/collator-selection/src/lib.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/lib.rs Show resolved Hide resolved
pallets/collator-selection/src/lib.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/lib.rs Outdated Show resolved Hide resolved
@joepetrowski @Ank4n
typos
37c853c 
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
@kianenigma kianenigma requested a review from gpestana May 22, 2023 07:16
bkchr
bkchr approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes to the migration to ensure that it works properly.

pallets/collator-selection/src/migration.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/migration.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/migration.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/migration.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/migration.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/migration.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/migration.rs Outdated Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team May 24, 2023 12:11
@joepetrowski @bkchr
Apply suggestions from code review
dfcbd35 
Co-authored-by: Bastian Köcher <git@kchr.de>
gpestana
gpestana approved these changes May 26, 2023
View reviewed changes
Copy link

@gpestana gpestana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of suggestions in the tests, but overall lgmt.

pallets/collator-selection/src/tests.rs Show resolved Hide resolved
pallets/collator-selection/src/tests.rs Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team May 29, 2023 10:31
@paritytech-ci paritytech-ci requested a review from a team May 29, 2023 10:33
@paritytech-ci paritytech-ci requested a review from a team May 29, 2023 10:39
@joepetrowski
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit abccfae into master May 29, 2023
@paritytech-processbot paritytech-processbot bot deleted the joe-addremove-invulnerable branch May 29, 2023 13:03
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ank4n Ank4n Ank4n approved these changes

@bkchr bkchr bkchr approved these changes

@kianenigma kianenigma kianenigma approved these changes

@gpestana gpestana gpestana approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joepetrowski @gpestana @kianenigma @bkchr @Ank4n