v16: ExtrinsicMetadata extensions #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
lexnv
commented
Nov 6, 2024
frame-metadata/src/v16.rs
Outdated
| @@ -223,22 +217,25 @@ impl IntoPortable for ExtrinsicMetadata { | |||
| serde(bound(serialize = "T::Type: Serialize, T::String: Serialize")) | |||
| )] | |||
| pub struct TransactionExtensionMetadata<T: Form = MetaForm> { | |||
| /// Extension version. | |||
| pub version: u8, | |||
There was a problem hiding this comment.
I've moved the version here, instead of having pub transaction_extensions: Vec<(u8, TransactionExtensionMetadata<T>)>.
Wdyt? // cc @jsdw @niklasad1 🙏
jsdw
reviewed
Nov 6, 2024
frame-metadata/src/v16.rs
Outdated
| @@ -223,22 +217,25 @@ impl IntoPortable for ExtrinsicMetadata { | |||
| serde(bound(serialize = "T::Type: Serialize, T::String: Serialize")) | |||
| )] | |||
| pub struct TransactionExtensionMetadata<T: Form = MetaForm> { | |||
| /// Extension version. | |||
| pub version: u8, | |||
There was a problem hiding this comment.
In V5 transactions we'll have a single u8 version denoting the set of transaction extensions to use. So while we could use this approach and have eg:
vec![
// v0 extensions
TransactionExtensionMetadata { version: 0, identifier: "Foo", ty: 123, implicit: 456 },
TransactionExtensionMetadata { version: 0, identifier: "Bar", ty: 124, implicit: 457 },
// v1 extensions
TransactionExtensionMetadata { version: 1, identifier: "Foo", ty: 123, implicit: 456 },
TransactionExtensionMetadata { version: 1, identifier: "Bar", ty: 124, implicit: 457 },
TransactionExtensionMetadata { version: 1, identifier: "Wibble", ty: 124, implicit: 457 },
// ...
]
(noting that the order of extensions within each version is important)
It perhaps makes more sense to avoid the repetition and represent extensions something like:
// For each supported version number, list the indexes, in order, of the extensions used:
versions: Map<u8, Vec<u32>> {
0: [0,1],
1: [0,1,2]
},
// All of the extensions used. The above refers to these by index:
extensions: vec![
TransactionExtensionMetadata { identifier: "Foo", ty: 123, implicit: 456 },
TransactionExtensionMetadata { identifier: "Bar", ty: 124, implicit: 457 },
TransactionExtensionMetadata { identifier: "Foo", ty: 123, implicit: 456 },
TransactionExtensionMetadata { identifier: "Bar", ty: 124, implicit: 457 },
TransactionExtensionMetadata { identifier: "Wibble", ty: 124, implicit: 457 },
]
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
jsdw
reviewed
Nov 6, 2024
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
jsdw
approved these changes
Nov 7, 2024
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
jsdw
reviewed
Nov 12, 2024
Co-authored-by: James Wilson <james@jsdw.me>
niklasad1
approved these changes
Nov 12, 2024
niklasad1
reviewed
Nov 12, 2024
| /// The type of the additional transaction data, with the data to be included in the signed payload. | ||
| pub additional_signed: T::Type, | ||
| /// The type of the implicit data, with the data to be included in the signed payload. | ||
| pub implicit: T::Type, |
There was a problem hiding this comment.
ok, missed that this has been renamed good to know
pkhry
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following to the v16 metadata:
ExtrinsicMetadata::call_tyas it can be found in the other enums field of the metadataExtrinsicMetadata::extra_tyas it can be found in the tx extensionsTransactionExtensionMetadata::additional_signedtoTransactionExtensionMetadata::implicitTransactionExtensionMetadata::versionu8 for versioning extensionscc @paritytech/subxt-team