Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Release v18.0.0 with unstable v16 ExtrinsicMetadata extensions #87

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Nov 12, 2024

[18.0.0] - 2024-11-13

Changed

  • v16: ExtrinsicMetadata extensions #86

cc @paritytech/subxt-team

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv self-assigned this Nov 12, 2024

### Changed

- v16: ExtrinsicMetadata extensions [#86](https://github.com/paritytech/frame-metadata/pull/86)
Copy link
Member

@niklasad1 niklasad1 Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a breaking change i.e. some public fields of the ExtrinsicMetadata are changed? Or we don't mind because it's hidden behind the unstable feature?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's tough. The "unstable" means we are allowed to break it without caring, but that sort of approach does also mean any crate depending on the unstable feature would start breaking until updated. (eg polkadot-sdk and merkleized-metadata)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yep, its a tough call, in the past we had breaking change for unstable versions (ie v15.1 included v15unstable). But since we cut a v17.0 for v16 unstable, I think its fine to do a v18 as well (just to keep consistency with our latest release schedules)

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv changed the title chore: Release v17.1.0 with unstable v16 ExtrinsicMetadata extensions chore: Release v18.0.0 with unstable v16 ExtrinsicMetadata extensions Nov 13, 2024
@lexnv
Copy link
Contributor Author

lexnv commented Nov 13, 2024

Testing Done

V16 unstable extrinsics

      "extrinsic": {
        "versions": [
          4,
          5
        ],
        "address_ty": 167,
        "signature_ty": 316,
        "transaction_extensions_by_version": {
          "0": [
            0,
            1,
            2,
            3,
            4,
            5,
            6,
            7,
            8
          ]
        },
        "transaction_extensions": [
          {
            "identifier": "CheckNonZeroSender",
            "ty": 537,
            "implicit": 34
          },
          {
            "identifier": "CheckSpecVersion",
            "ty": 538,
            "implicit": 4
          },
          {
            "identifier": "CheckTxVersion",
            "ty": 539,
            "implicit": 4
          },
          {
            "identifier": "CheckGenesis",
            "ty": 540,
            "implicit": 13
          },
          {
            "identifier": "CheckMortality",
            "ty": 541,
            "implicit": 13
          },
          {
            "identifier": "CheckNonce",
            "ty": 543,
            "implicit": 34
          },
          {
            "identifier": "CheckWeight",
            "ty": 544,
            "implicit": 34
          },
          {
            "identifier": "ChargeAssetTxPayment",
            "ty": 545,
            "implicit": 34
          },
          {
            "identifier": "CheckMetadataHash",
            "ty": 547,
            "implicit": 96
          }
        ]
      },

V15 extrinsics

The call type is removed from v16 because it is identical to the other call enum:

      "outer_enums": {
        // 142 identical to extrinsic call_ty 142
        "call_enum_ty": 142,
        "event_enum_ty": 21,
        "error_enum_ty": 1056
      },
"extrinsic": {
        "version": 4,
        "address_ty": 167,
        "call_ty": 142,
        "signature_ty": 316,
        "extra_ty": 954,
        "signed_extensions": [
          {
            "identifier": "CheckNonZeroSender",
            "ty": 955,
            "additional_signed": 34
          },
          {
            "identifier": "CheckSpecVersion",
            "ty": 956,
            "additional_signed": 4
          },
          {
            "identifier": "CheckTxVersion",
            "ty": 957,
            "additional_signed": 4
          },
          {
            "identifier": "CheckGenesis",
            "ty": 958,
            "additional_signed": 13
          },
          {
            "identifier": "CheckMortality",
            "ty": 959,
            "additional_signed": 13
          },
          {
            "identifier": "CheckNonce",
            "ty": 961,
            "additional_signed": 34
          },
          {
            "identifier": "CheckWeight",
            "ty": 962,
            "additional_signed": 34
          },
          {
            "identifier": "ChargeAssetTxPayment",
            "ty": 963,
            "additional_signed": 34
          },
          {
            "identifier": "CheckMetadataHash",
            "ty": 965,
            "additional_signed": 96
          }
        ]
      },

@lexnv lexnv merged commit c67d5c8 into main Nov 13, 2024
9 checks passed
@lexnv lexnv deleted the lexnv/release-version branch November 13, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants