txWatch: Remove the txWatch limits #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
This was referenced Apr 17, 2024
jsdw
approved these changes
Apr 17, 2024
|
So this PR is identical to #150 |
tomaka
approved these changes
Apr 17, 2024
niklasad1
approved these changes
Apr 17, 2024
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Apr 19, 2024
This PR stabilizes the txBroadcast API to version 1. Needs from spec: - paritytech/json-rpc-interface-spec#153 - paritytech/json-rpc-interface-spec#154 cc @paritytech/subxt-team --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup of the proposal from: #150 (review)
In this PR, the concept of limits is removed from the
transactionWatch, as noted in: #150.Transaction::Droppedif the node cannot keep up with the number of transactions (as per spec), however servers are not required to support a minimum of 4 subscriptions per clientcc @paritytech/subxt-team @tomaka