Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txWatch: Stabilize txWatch to version 1 #4171

Merged
merged 6 commits into from
Apr 19, 2024
Merged

txWatch: Stabilize txWatch to version 1 #4171

merged 6 commits into from
Apr 19, 2024

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Apr 17, 2024

This PR stabilizes the txBroadcast API to version 1.

Needs from spec:

cc @paritytech/subxt-team

@lexnv
txWatch: Stabilize txWatch to version 1
62018cc 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv added A0-needs_burnin Pull request needs to be tested on a live validator node before merge. DevOps is notified via matrix I5-enhancement An additional feature request. T3-RPC_API This PR/Issue is related to RPC APIs. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Apr 17, 2024
@lexnv lexnv self-assigned this Apr 17, 2024
@lexnv
prdoc: Add prdoc
6ea5bdf 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv mentioned this pull request Apr 17, 2024
Open
@lexnv lexnv enabled auto-merge April 18, 2024 11:33
@lexnv lexnv disabled auto-merge April 19, 2024 08:39
@lexnv lexnv mentioned this pull request Apr 19, 2024
Merged
@lexnv lexnv added this pull request to the merge queue Apr 19, 2024
Merged via the queue into master with commit eba3dec Apr 19, 2024
136 of 137 checks passed
@lexnv lexnv deleted the lexnv/txwatch-bv1 branch April 19, 2024 10:32
@lexnv lexnv mentioned this pull request Apr 19, 2024
Closed
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
@Niederb Niederb mentioned this pull request Jul 1, 2024
Merged
@TDemeco TDemeco mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@jsdw jsdw jsdw approved these changes

Assignees

@lexnv lexnv

Labels
A0-needs_burnin Pull request needs to be tested on a live validator node before merge. DevOps is notified via matrix D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I5-enhancement An additional feature request. T3-RPC_API This PR/Issue is related to RPC APIs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lexnv @jsdw @niklasad1