-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ⏫ upgrade to Polkadot SDK v1.11.0 #212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowmead
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, just wanted to clarify the use of having both rust-libp2p and litep2p network backends.
ffarall
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, outstanding PR docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update from Polkadot SDK 1.10.0 to 1.11.0
Changelog for
Node Dev
:candidates_pending_availability
runtime API, which returns all the candidates for a parachain at a given relay block number (useful for elastic scaling)para_id()
from CoreState in polkadot primitives in favor of direct usage of ClaimQueue (which provides a better view of what’s scheduled on each core). Again, useful to know for elastic scalingTransactionEvent
sframe-omni-bencher
that allows to directly benchmark a WASM blob without needing a node or chain spec, making it easier to generate pallet weights. It works for all FRAME runtimes that don’t have 3rd party host calls (we don’t) or nonBlakeTwo256
block hashing (we do) so it should work for us. It is backwards compatible with the old CLI args too.—runtime
and—genesis-builder=none|runtime|spec
arguments to thebenchmark pallet
commandPalletCmd::run
:run()
is deprecated, we either remove all benchmark code from the Node and use the new omni-bencher or change it forrun_with_spec()
.run_with_spec
temporarily, although when we start benchmarking we should remove all benchmarking code from the node and use theomni-bencher
as recommended.local
,staging
, etc). To use them, the ChainSpecBuilder is extended with thewith_genesis_config_preset_name
method.GenesisBuilder
API changed to make use of these presets, I already updated it on our runtime but we don’t have any presets yet, it’s worth exploring if we could make good use of them. Usage example for Rococo herelitep2p
integrated into Polkadot SDK improving performance but not fully replacingrust-libp2p
yet.NetworkBackend
type, which can be good old libp2p or new flashy litep2p. Took a while 😮💨slot_duration
fromaura::collators::basic::Params
, it now has to be fetched using Aura’s runtime APInode/src/service.rs
+ removed unneeded code fromnode/src/command.rs
(logging parachain account)Changelog for
Runtime Dev
:pallet-broker
to get the current price of a core in the ongoing saleframe/examples
andMigrationId
to frame-supportCurrency
toFungible
FungibleAdapter
andfile-system
pallet since it was using the to-be-deprecated Currency traitdynamic_params
name expand onpallet-parameters
validate_unsigned
hook forframe-system
allows valid tasks to be submitted as unsigned transactionsis_valid
call on a task is the one that validates if the task is valid to be submitted as an unsigned transaction. As such, to prevent DoS attacks, it has to be cheap with minimal to no storage reads.substrate/frame/examples/tasks/
AllowHrmpNotificationsFromRelayChain
barrier for safety (to ensure HRMP notifications originate solely from the Relay Chain)xcm-simulator
and the actual runtime.hrmp.establish_channel_with_system
call to allow parachains to establish a channel with a system parachainTryRuntime
subcommand from node (we should use the standalone CLI https://github.com/paritytech/try-runtime-cli)execute_blob
andsend_blob
and restoringexecute
andsend
Extra changes:
CheckMetadataHash
extension according to RFC 0078 (also check #4274)