-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy pallet-parameters
to rococo and fix dynamic_params name expand
#4006
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
pallet-parameters
to rococopallet-parameters
to rococo and fix dynamic_params name expand
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
bot bench polkadot-pallet --pallet=pallet_parameters --runtime rococo |
@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5802521 was started for your command Comment |
The CI pipeline was cancelled due to failure one of the required jobs. |
This PR introduces a dedicated module for benchmarks within the parachain runtime. By segregating benchmarks into their own module, we achieve a cleaner project structure and improved readability, facilitating easier maintenance and updates. ### Key Changes: - **New Benchmarks Module**: A new file `benchmarks.rs` is added, encapsulating the benchmarking code for various pallets. - **Refactoring `lib.rs`**: The main runtime library file (`lib.rs`) has been updated to reflect the extraction of benchmark definitions. By moving these definitions to `benchmarks.rs`, we reduce clutter in `lib.rs`, streamlining the runtime's core logic and configuration. ### Benefits of This Refactoring: - **Focused Benchmarking**: Developers can now easily locate and modify benchmarks without navigating through the core runtime logic, enabling targeted performance improvements. - **Cleaner Codebase**: Segregating benchmarks from the main runtime logic helps maintain a clean, well-organized codebase, simplifying navigation and maintenance. - **Scalability**: As the parachain evolves, adding or updating benchmarks becomes more straightforward, supporting scalability and adaptability of the runtime. ### Summary of Changes: - Created `benchmarks.rs` to house the benchmarking suite. - Streamlined `lib.rs` by removing the inlined benchmark definitions and linking to the new benchmarks module. --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
…=rococo --target_dir=polkadot --pallet=pallet_parameters
@ggwpez Command |
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Changes:
to_class_case
removes suffixs
, andNis
becomesNi
😑. Now usingto_pascal_case
.