Rename crate #4
Rename crate #4
Conversation
| version = "0.6.0" | ||
| authors = ["Nervos Core Dev <dev@nervos.org>"] | ||
| edition = "2018" | ||
| license = "MIT" | ||
| description = "A generalized merkle mountain range implementation" | ||
| description = "A generalized merkle mountain range implementation (polkadot fork)" |
There was a problem hiding this comment.
Should we also change the repository below to https://github.com/paritytech/merkle-mountain-range ? Or should we keep the original one that we forked ? Just asking, not sure what's the procedure.
The same question for the authors field.
There was a problem hiding this comment.
Also not sure if from a licensing point of view this is ok. Or if we have to do something extra. @Morganamilo Do you happen to know ?
There was a problem hiding this comment.
Yea repo should be changed i think. For the authors we can mention Nervos and Parity, since you modified it.
There was a problem hiding this comment.
Yea repo should be changed i think. For the authors we can mention Nervos and Parity, since you modified it.
And Robert Hambrock <roberthambrock@gmail.com>
There was a problem hiding this comment.
License is fine upstream really should have a LICENSE file with their copyright attrib but they don't. I'll change the repo and authors.
There was a problem hiding this comment.
I added parity as an author. where does Robert come from?
There was a problem hiding this comment.
License is fine upstream really should have a LICENSE file with their copyright attrib but they don't. I'll change the repo and authors.
Ok. Please also add Robert Hambrock <roberthambrock@gmail.com> to the authors. He contributed with this PR: #1 which is basically our main change in the fork
No description provided.