Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename crate #4

Merged
merged 3 commits into from
May 24, 2024
Merged

Rename crate #4

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3caeeb
Rename crate
Morganamilo May 23, 2024
c1ca95b
Update metadata
Morganamilo May 23, 2024
f641188
Add author
Morganamilo May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
[package]
name = "ckb-merkle-mountain-range"
name = "polkadot-ckb-merkle-mountain-range"
version = "0.6.0"
authors = ["Nervos Core Dev <dev@nervos.org>"]
edition = "2018"
license = "MIT"
description = "A generalized merkle mountain range implementation"
description = "A generalized merkle mountain range implementation (polkadot fork)"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also change the repository below to https://github.com/paritytech/merkle-mountain-range ? Or should we keep the original one that we forked ? Just asking, not sure what's the procedure.

The same question for the authors field.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not sure if from a licensing point of view this is ok. Or if we have to do something extra. @Morganamilo Do you happen to know ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea repo should be changed i think. For the authors we can mention Nervos and Parity, since you modified it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea repo should be changed i think. For the authors we can mention Nervos and Parity, since you modified it.

And Robert Hambrock <roberthambrock@gmail.com>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License is fine upstream really should have a LICENSE file with their copyright attrib but they don't. I'll change the repo and authors.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added parity as an author. where does Robert come from?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License is fine upstream really should have a LICENSE file with their copyright attrib but they don't. I'll change the repo and authors.

Ok. Please also add Robert Hambrock <roberthambrock@gmail.com> to the authors. He contributed with this PR: #1 which is basically our main change in the fork

repository = "https://github.com/nervosnetwork/merkle-mountain-range"

[features]
Expand Down