Ws-port argument has been repalced with rpc-port #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
the
A-chores
|
uff, sorry for that, I knew that I forgot something, to check dockers yesterday :( |
It's fine :) Rialto<>Millau exist to be broken and detect such changes |
bkontur
approved these changes
May 17, 2023
svyatonik
commented
May 18, 2023
svyatonik
commented
May 18, 2023
| @@ -502,8 +502,8 @@ pub async fn start_node( | |||
| keystore, | |||
| force_authoring, | |||
| slot_duration, | |||
| // We got around 500ms for proposing | |||
| block_proposal_slot_portion: SlotProportion::new(1f32 / 24f32), | |||
| // We got around 1000ms for proposing | |||
There was a problem hiding this comment.
This has caused problems for me - parachain was unable to produce any blocks within 500ms, so I've increased it to 1s.
svyatonik
commented
May 18, 2023
| @@ -9,68 +9,74 @@ services: | |||
| entrypoint: > | |||
| /home/user/rialto-parachain-collator | |||
| --alice | |||
| --node-key=80cf382988364291a7968ae7825c01f68c50d679796a8983237d07fe0ccf363b | |||
There was a problem hiding this comment.
There were some recent changes in networking && I guess our parachain nodes can't connect to each other because of that => I've added stuff similar to what we have in Rialto and Millau
serban300
approved these changes
May 18, 2023
Merged
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
* Skip verification on state import * Actually use existing variables * Merge checks
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* ws-port argument has been repalced with rpc-port * fixed paras pallet weight and expose unsigned validation * add bootnodes to RialtoParachain collators * another bump + increase block proposal time * revert RUST_LOG=trace for test network nodes
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* ws-port argument has been repalced with rpc-port * fixed paras pallet weight and expose unsigned validation * add bootnodes to RialtoParachain collators * another bump + increase block proposal time * revert RUST_LOG=trace for test network nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #2134 and #2138
This PR:
ws-portargument has been removed;