separate constants for average and worst case relay headers #2728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to move bridge fees towards expected after paritytech/polkadot-sdk#2139 . There I've used existing
AVERAGE_HEADER_SIZE_IN_JUSTIFICATION
constants, which are actually worst possible header size. Once this PR is merged, we'll keep using worst possible const for computing maximal refund, but for computing fees we'll be using average header size. Side effects:FEE
;MaxFEE
, which is larger than theFEE
;MaxFEE - FEE
will be paid by the SA of AH.In real world, however, we'll be running our own realyer (at least for v1), which is configured to deliver messages/confirmations asap and will select the header without looking at its size. Since we expect headers to have the
AVERAGE_HEADER_SIZE_IN_JUSTIFICATION
, not theWORST_HEADER_SIZE_IN_JUSTIFICATION
. So the actual fee in average will be closer to theFEE
, not theMaxFEE
.