Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split off implementation of MallocSizeOf for primitive-types #323

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Split off implementation of MallocSizeOf for primitive-types #323

merged 1 commit into from
Feb 4, 2020

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Feb 3, 2020

No description provided.

ordian
ordian reviewed Feb 3, 2020
View reviewed changes
parity-util-mem/Cargo.toml Outdated Show resolved Hide resolved
@ordian
Copy link
Member

ordian commented Feb 3, 2020

test failure seems legit (use >=?)

failures:
---- primitives_impls::tests::smoky stdout ----
thread 'primitives_impls::tests::smoky' panicked at 'assertion failed: `(left == right)`
  left: `72`,
 right: `64`', parity-util-mem/src/primitives_impls.rs:32:3
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
failures:
    primitives_impls::tests::smoky
test result: FAILED. 5 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
error: test failed, to rerun pass '-p parity-util-mem --lib'
The command "cargo test --all --exclude uint --exclude fixed-hash" exited with 101.

@NikVolf
Copy link
Contributor Author

NikVolf commented Feb 3, 2020

@ordian updated!

@ordian
Copy link
Member

ordian commented Feb 3, 2020

(would be nice to update the changelog as well)

@NikVolf
Copy link
Contributor Author

NikVolf commented Feb 3, 2020

Build fail seems unrelated to changes

@ordian
Copy link
Member

ordian commented Feb 3, 2020

Build fail seems unrelated to changes

opened #324

@NikVolf NikVolf mentioned this pull request Feb 3, 2020
Merged
@NikVolf
Copy link
Contributor Author

NikVolf commented Feb 4, 2020

(would be nice to update the changelog as well)

I'll update it when publishing 0.4.2

@ordian ordian merged commit 8440c05 into master Feb 4, 2020
@ordian ordian deleted the nv-mem-primitives branch February 4, 2020 11:23
dvdplm added a commit that referenced this pull request Feb 4, 2020
@dvdplm
Merge branch 'master' into dp/chore/secp256k1-from-upstream
c5ac1f9 
* master:
  update changelogs (#329)
  bump parity-util-mem to 0.4.2 (#328)
  remove libc feature from fixed-hash (#317)
  kvdb-rocksdb: release 0.4.2 (#327)
  kvdb-rocksdb: fix iter_from_prefix being slow (#326)
  MallocSizeOf for BTreeSet (#325)
  split off primitives (#323)
  travis: disable kvdb-web tests for chrome (#324)
  Expand const fn coverage (#319)
  uint: make zero const fn (#318)
  README: fix appveyor badge (#316)
  keccak-hash: switch benches to criterion (#315)
ordian added a commit that referenced this pull request Feb 6, 2020
@ordian
Merge branch 'master' into ao-kvdb-sled
9ba45b7 
* master: (56 commits)
  Remove libc completely (#333)
  update changelogs (#329)
  bump parity-util-mem to 0.4.2 (#328)
  remove libc feature from fixed-hash (#317)
  kvdb-rocksdb: release 0.4.2 (#327)
  kvdb-rocksdb: fix iter_from_prefix being slow (#326)
  MallocSizeOf for BTreeSet (#325)
  split off primitives (#323)
  travis: disable kvdb-web tests for chrome (#324)
  Expand const fn coverage (#319)
  uint: make zero const fn (#318)
  README: fix appveyor badge (#316)
  keccak-hash: switch benches to criterion (#315)
  update parity-util-mem (#309)
  Update features and feature dependencies (#307)
  Use proper memory queries to rocksdb (#308)
  Draft version updates and changelog (#299)
  Use custom error type for `from_hex` (#305)
  Fix typo. (#303)
  kvdb: remove KeyValueDBHandler (#304)
  ...
ordian added a commit that referenced this pull request Feb 7, 2020
@ordian
Merge branch 'master' into ao-no-overlay
7fb861a 
* master:
  Add different mode for malloc_size_of_is_0 macro dealing with generics (#334)
  [parity-crypto] Use upstream secp256k1 (#258)
  Bump parking_lot to 0.10 and minor versions (#332)
  Remove libc completely (#333)
  update changelogs (#329)
  bump parity-util-mem to 0.4.2 (#328)
  remove libc feature from fixed-hash (#317)
  kvdb-rocksdb: release 0.4.2 (#327)
  kvdb-rocksdb: fix iter_from_prefix being slow (#326)
  MallocSizeOf for BTreeSet (#325)
  split off primitives (#323)
  travis: disable kvdb-web tests for chrome (#324)
  Expand const fn coverage (#319)
  uint: make zero const fn (#318)
  README: fix appveyor badge (#316)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A8-looksgood
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikVolf @ordian