-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[parity-crypto] Use upstream secp256k1 #258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Compile triehash for no_std (#280) [kvdb-rocksdb] Use "pinned" gets to avoid allocations (#274) [kvdb-rocksdb] Release 0.2 (#273) [kvdb-rocksdb] switch to upstream (#257) travis: try to fix wasmpack chrome test on macOS (#263) Use 2018 edition for rustfmt (#266) [fixed-hash]: re-export `alloc_` (#268) kvdb-web: async-awaitify (#259) kvdb-rocksdb: configurable memory budget per column (#256) Bump rlp crate version. (#270) Introduce Rlp::at_with_offset method. (#269) Make fixed-hash test structs public (#267) Migrate primitive types to 2018 edition (#262) upgrade tiny-keccak to 2.0 (#260)
* master: (27 commits) update parity-util-mem (#309) Update features and feature dependencies (#307) Use proper memory queries to rocksdb (#308) Draft version updates and changelog (#299) Use custom error type for `from_hex` (#305) Fix typo. (#303) kvdb: remove KeyValueDBHandler (#304) extract common kvdb tests into a crate (#301) Expose to_hex and from_hex from impl-serde (#302) Add a top level function to parity-util-mem (#298) I/O statistic for key-value databases (#294) use for_tuples (#300) Add memory extensions for LRUCache, hashbrown (#293) Add memory stats for kvdb-s (#292) Provide #[derive(MallocSizeOf)] that is actually working (#291) Move and extend impls for locking primitives (#290) Update uint README (#288) Update README.md (#287) [ci]: remove feature flags in virtual workspace (#289) Prepare releases (#286) ...
…y graph requires `= 0.8.0`
dvdplm
commented
Jan 29, 2020
ordian
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (I'm not a cryptographer)
* master: update changelogs (#329) bump parity-util-mem to 0.4.2 (#328) remove libc feature from fixed-hash (#317) kvdb-rocksdb: release 0.4.2 (#327) kvdb-rocksdb: fix iter_from_prefix being slow (#326) MallocSizeOf for BTreeSet (#325) split off primitives (#323) travis: disable kvdb-web tests for chrome (#324) Expand const fn coverage (#319) uint: make zero const fn (#318) README: fix appveyor badge (#316) keccak-hash: switch benches to criterion (#315)
sorpaas
approved these changes
Feb 6, 2020
ordian
added a commit
that referenced
this pull request
Feb 7, 2020
* master: Add different mode for malloc_size_of_is_0 macro dealing with generics (#334) [parity-crypto] Use upstream secp256k1 (#258) Bump parking_lot to 0.10 and minor versions (#332) Remove libc completely (#333) update changelogs (#329) bump parity-util-mem to 0.4.2 (#328) remove libc feature from fixed-hash (#317) kvdb-rocksdb: release 0.4.2 (#327) kvdb-rocksdb: fix iter_from_prefix being slow (#326) MallocSizeOf for BTreeSet (#325) split off primitives (#323) travis: disable kvdb-web tests for chrome (#324) Expand const fn coverage (#319) uint: make zero const fn (#318) README: fix appveyor badge (#316)
dvdplm
added a commit
that referenced
this pull request
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to
rust-secp256k1
atv0.17.2
and address the two changes in theparity-secp256k1
fork that has thus far prevented us from switching:secret-store
.This is solved by using
libsecp256k1
in the one place inparity-ethereum
that needs the inversion (we need the yet unreleasedv0.3.5
). See openethereum/parity-ethereum#11406.The other changes in this PR are mostly due to refactorings and improvements upstream to make the API harder to misuse. Some operations that previously could fail now don't, e.g. generate a random key pair; many methods that needed a
Secp256k1
context now don't etc. Extra context here.