-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all references in Cargo.lock for patched crates #89
Conversation
sort | | ||
uniq | ||
) | ||
cargo update "${comp_update_args[@]}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't it conflict with --locked flag?
#88
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because cargo check
is being executed without the --locked
flag below, as intended: Cargo.lock will invariably need to be updated because we're patching packages into projects
It's working as per https://gitlab.parity.io/parity/mirrors/substrate/builds/2117207 and https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2117249 |
This reverts commit 843b042.
Works around https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2115137#L1544
Comparing https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2115137#L1544, which failed to compile
polkadot-node-subsystem-test-helpers
with errors such aswith https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2116743#L1811, which got past that point, I think that the fix is effective.
ref paritytech/substrate#12837 (comment)