Rename some crates for publishing to crates.io

[joao-paulo-parity]

For context see https://forum.parity.io/t/new-names-suggestions-for-squatted-crates/1513.

close https://github.com/paritytech/release-engineering/issues/132

polkadot companion: paritytech/polkadot#6385
cumulus companion: paritytech/cumulus#1944

[bkchr]

Besides the one nitpick, it looks good.

[bkchr]

Suggested change

	name = "remote-ext"
	name = "frame-remote-ext"

Or something similar, but it should be more expressive.

CC @kianenigma

[joao-paulo-parity]

The other name I've reserved is frame-remote-externalities. I'll change to that, then.

[joao-paulo-parity]

Failure of https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2115137#L1544 seems to be related to a bug in check_dependent_project.sh. Let me see if I can fix that. Moving to Draft in the meantime.

[joao-paulo-parity]

I think the fix was effective as per https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2116743#L1811 which didn't fail to compile polkadot-node-subsystem-test-helpers like https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2115137#L1544. Now it's failing with a different error which appears to be unrelated to this PR:

Checking cumulus-relay-chain-inprocess-interface v0.1.0 (/builds/parity/mirrors/substrate/companions/cumulus/client/relay-chain-inprocess-interface)
error[E0308]: mismatched types
  --> client/relay-chain-minimal-node/src/network.rs:75:4
   |
75 | /             Some(Box::new(move |fut| {
76 | |                 spawn_handle.spawn("libp2p-node", Some("networking"), fut);
77 | |             }))
   | |_______________^ expected struct `Box`, found enum `std::option::Option`
   |
   = note: expected struct `Box<(dyn std::ops::Fn(Pin<Box<(dyn futures::Future<Output = ()> + std::marker::Send + 'static)>>) + std::marker::Send + 'static)>`
                found enum `std::option::Option<Box<[closure@client/relay-chain-minimal-node/src/network.rs:75:18: 75:28]>>`

I'll try to fix that.

[joao-paulo-parity]

The "different error" I mentioned in #12837 (comment) is very likely unrelated to this PR. I found a fix for it in paritytech/cumulus@747400a, i.e. it's related to #12646.

Fixed as per https://gitlab.parity.io/parity/mirrors/substrate/builds/2117207

[acatangiu]

nit:

Why not go full rename from the get-go?

Suggested change

	beefy-primitives = { version = "4.0.0-dev", path = "../../primitives/beefy", package = "sp-beefy" }
	sp-beefy = { version = "4.0.0-dev", path = "../../primitives/beefy" }

[joao-paulo-parity]

That would incur touching the .rs files as well, right? I followed @athei 's suggestion from https://forum.parity.io/t/new-names-suggestions-for-squatted-crates/1513/2 of only changing the Cargo.tomls.

I went with this approach because it minimizes the amount of changes I have to do in this PR and the companions. However, I'm open to whatever approach is the most agreed upon. Changing the .rs files wouldn't be difficult, it'd just be more work. Also it might require more reviews from other teams.

Do you strongly prefer the full rename or is it acceptable to leave it like this?

[acatangiu]

Unless there's some hurry with this PR, I would prefer the full rename, otherwise you can kick the can down the road and someone will do it later; not blocking the PR on this :)

[ggwpez]

I think we are a bit in a hurry with it; since we want to release the crates ASAP.

[joao-paulo-parity]

bot merge