Merge branch 'tsv-disabling-backing' into ao-disabling-statement-dist…

…ribution

* tsv-disabling-backing: (54 commits)
  Publish `xcm-emulator` crate (#1881)
  Adding migrations to clean Rococo Gov 1 storage & reserved funds (#1849)
  Arkworks Elliptic Curve utils overhaul (#1870)
  Fix typos (#1878)
  fix: GoAhead signal only set when runtime upgrade is enacted from parachain side (#1176)
  Refactor staking ledger (#1484)
  Paired-key Crypto Scheme (#1705)
  Include polkadot version in artifact path (#1828)
  add link to rfc-0001 in broker README (#1862)
  Discard `Executor` (#1855)
  Macros to use path instead of ident (#1474)
  Remove clippy clone-double-ref lint noise (#1860)
  Refactor alliance benchmarks to v2 (#1868)
  Check executor params coherence (#1774)
  frame: use derive-impl for beefy and mmr pallets (#1867)
  sc-consensus-beefy: improve gossip logic (#1852)
  Adds instance support for composite enums (#1857)
  Fix links to implementers' guide (#1865)
  Disabled validators runtime API (#1257)
  Adding `try_state` hook for `Treasury` pallet (#1820)
  ...

.cargo/config.toml

@@ -1,4 +1,9 @@
-#
+[build]
+rustdocflags = [
+ "-Dwarnings",
+ "-Arustdoc::redundant_explicit_links", # stylistic
+]
+
 # An auto defined `clippy` feature was introduced,
 # but it was found to clash with user defined features,
 # so was renamed to `cargo-clippy`.
@@ -10,7 +15,7 @@ rustflags = [
  "-Aclippy::all",
  "-Dclippy::correctness",
  "-Aclippy::if-same-then-else",
- "-Aclippy::clone-double-ref",
+ "-Asuspicious_double_ref_op",
  "-Dclippy::complexity",
  "-Aclippy::zero-prefixed-literal", # 00_1000_000
  "-Aclippy::type_complexity", # raison d'etre
@@ -30,4 +35,5 @@ rustflags = [
  "-Aclippy::derivable_impls", # false positives
  "-Aclippy::stable_sort_primitive", # prefer stable sort
  "-Aclippy::extra-unused-type-parameters", # stylistic
+ "-Aclippy::default_constructed_unit_structs", # stylistic
 ]

.github/review-bot.yml

@@ -10,7 +10,7 @@ rules:
  - ^\.cargo/.*
  exclude: 
  - ^./gitlab/pipeline/zombienet.*
- min_approvals: 2
+ minApprovals: 2
  type: basic
  teams:
  - ci
@@ -27,7 +27,7 @@ rules:
  exclude: 
  - ^polkadot/runtime\/(kusama|polkadot)\/src\/weights\/.+\.rs$
  - ^substrate\/frame\/.+\.md$
- min_approvals: 1
+ minApprovals: 1
  allowedToSkipRule:
  teams:
  - core-devs
@@ -54,7 +54,7 @@ rules:
  - ^\.gitlab/.*
  - ^\.config/nextest.toml
  - ^\.cargo/.*
- min_approvals: 2
+ minApprovals: 2
  type: basic
  teams:
  - core-devs
@@ -70,10 +70,10 @@ rules:
  - ^cumulus/parachains/common/src/[^/]+\.rs$
  type: and-distinct
  reviewers:
- - min_approvals: 1
+ - minApprovals: 1
  teams:
  - locks-review
- - min_approvals: 1
+ - minApprovals: 1
  teams:
  - polkadot-review
 
@@ -83,7 +83,7 @@ rules:
  condition: 
  include:
  - ^bridges/.*
- min_approvals: 1
+ minApprovals: 1
  teams:
  - bridges-core
 
@@ -95,10 +95,10 @@ rules:
  - ^substrate/frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*|aura/.*))
  type: "and"
  reviewers:
- - min_approvals: 2
+ - minApprovals: 2
  teams:
  - core-devs
- - min_approvals: 1
+ - minApprovals: 1
  teams:
  - frame-coders
 
@@ -107,15 +107,14 @@ rules:
  condition:
  include: 
  - review-bot\.yml
- min_approvals: 2
  type: "and"
  reviewers:
- - min_approvals: 1
+ - minApprovals: 1
  teams:
  - opstooling
- - min_approvals: 1
+ - minApprovals: 1
  teams:
  - locks-review
- - min_approvals: 1
+ - minApprovals: 1
  teams:
  - ci

.github/workflows/review-bot.yml

@@ -24,7 +24,7 @@ jobs:
  app_id: ${{ secrets.REVIEW_APP_ID }}
  private_key: ${{ secrets.REVIEW_APP_KEY }}
  - name: "Evaluates PR reviews and assigns reviewers"
- uses: paritytech/review-bot@v1.1.0
+ uses: paritytech/review-bot@v2.0.1
  with:
  repo-token: ${{ secrets.GITHUB_TOKEN }}
  team-token: ${{ steps.team_token.outputs.token }}

.gitlab-ci.yml

@@ -30,7 +30,7 @@ variables:
  RUSTY_CACHIER_COMPRESSION_METHOD: zstd
  NEXTEST_FAILURE_OUTPUT: immediate-final
  NEXTEST_SUCCESS_OUTPUT: final
- ZOMBIENET_IMAGE: "docker.io/paritytech/zombienet:v1.3.68"
+ ZOMBIENET_IMAGE: "docker.io/paritytech/zombienet:v1.3.69"
  DOCKER_IMAGES_VERSION: "${CI_COMMIT_REF_NAME}-${CI_COMMIT_SHORT_SHA}"
 
 default:

.gitlab/pipeline/build.yml

@@ -91,6 +91,7 @@ build-rustdoc:
  - .run-immediately
  variables:
  SKIP_WASM_BUILD: 1
+ RUSTDOCFLAGS: ""
  artifacts:
  name: "${CI_JOB_NAME}_${CI_COMMIT_REF_NAME}-doc"
  when: on_success
@@ -99,7 +100,6 @@ build-rustdoc:
  - ./crate-docs/
  script:
  # FIXME: it fails with `RUSTDOCFLAGS="-Dwarnings"` and `--all-features`
- # FIXME: return to stable when https://github.com/rust-lang/rust/issues/96937 gets into stable
  - time cargo doc --features try-runtime,experimental --workspace --no-deps
  - rm -f ./target/doc/.lock
  - mv ./target/doc ./crate-docs

.gitlab/pipeline/test.yml

@@ -181,7 +181,6 @@ test-rustdoc:
  - .run-immediately
  variables:
  SKIP_WASM_BUILD: 1
- RUSTDOCFLAGS: "-Dwarnings"
  script:
  - time cargo doc --workspace --all-features --no-deps
  allow_failure: true