Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove clippy clone-double-ref lint noise #1860

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Remove clippy clone-double-ref lint noise #1860

merged 2 commits into from
Oct 13, 2023

Conversation

seadanda
Copy link
Contributor

@seadanda seadanda commented Oct 12, 2023 •
edited
Loading

The lint clippy::clone_double_ref was renamed to suspicious_double_ref_op in this commit (thanks @liamaharon) and now generates a lot of noise in the terminal when run both in CI and locally with 1.73.

This renames the lint in line with this, but does not change functionality.

May cause issues for people running earlier versions locally - @altaua requesting review to get your opinion on this.

@seadanda
Remove clippy clone-double-ref lint noise
6632b6e 
Rename `clippy::clone_double_ref` to `suspicious_double_ref_op`
@seadanda seadanda requested a review from altaua October 12, 2023 10:14
@paritytech-ci paritytech-ci requested review from a team October 12, 2023 10:16
@seadanda seadanda added the T10-tests This PR/Issue is related to tests. label Oct 12, 2023
@paritytech-ci paritytech-ci requested a review from a team October 12, 2023 12:11
liamaharon
liamaharon approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep: rust-lang/rust@5c99175

@seadanda seadanda enabled auto-merge (squash) October 12, 2023 13:40
@seadanda seadanda enabled auto-merge (squash) October 12, 2023 15:42
@seadanda seadanda merged commit 1f28cdd into master Oct 13, 2023
113 checks passed
@seadanda seadanda deleted the donal-reduce-clippy-noise branch October 13, 2023 21:06
ordian added a commit that referenced this pull request Oct 16, 2023
@ordian
Merge branch 'master' into tsv-disabling-backing
c44093d 
* master: (54 commits)
  Publish `xcm-emulator` crate (#1881)
  Adding migrations to clean Rococo Gov 1 storage & reserved funds (#1849)
  Arkworks Elliptic Curve utils overhaul (#1870)
  Fix typos (#1878)
  fix: GoAhead signal only set when runtime upgrade is enacted from parachain side (#1176)
  Refactor staking ledger (#1484)
  Paired-key Crypto Scheme (#1705)
  Include polkadot version in artifact path (#1828)
  add link to rfc-0001 in broker README (#1862)
  Discard `Executor` (#1855)
  Macros to use path instead of ident (#1474)
  Remove clippy clone-double-ref lint noise (#1860)
  Refactor alliance benchmarks to v2 (#1868)
  Check executor params coherence (#1774)
  frame: use derive-impl for beefy and mmr pallets (#1867)
  sc-consensus-beefy: improve gossip logic (#1852)
  Adds instance support for composite enums (#1857)
  Fix links to implementers' guide (#1865)
  Disabled validators runtime API (#1257)
  Adding `try_state` hook for `Treasury` pallet (#1820)
  ...
ordian added a commit that referenced this pull request Oct 16, 2023
@ordian
Merge branch 'tsv-disabling-backing' into ao-disabling-statement-dist…
b67c19f 
…ribution

* tsv-disabling-backing: (54 commits)
  Publish `xcm-emulator` crate (#1881)
  Adding migrations to clean Rococo Gov 1 storage & reserved funds (#1849)
  Arkworks Elliptic Curve utils overhaul (#1870)
  Fix typos (#1878)
  fix: GoAhead signal only set when runtime upgrade is enacted from parachain side (#1176)
  Refactor staking ledger (#1484)
  Paired-key Crypto Scheme (#1705)
  Include polkadot version in artifact path (#1828)
  add link to rfc-0001 in broker README (#1862)
  Discard `Executor` (#1855)
  Macros to use path instead of ident (#1474)
  Remove clippy clone-double-ref lint noise (#1860)
  Refactor alliance benchmarks to v2 (#1868)
  Check executor params coherence (#1774)
  frame: use derive-impl for beefy and mmr pallets (#1867)
  sc-consensus-beefy: improve gossip logic (#1852)
  Adds instance support for composite enums (#1857)
  Fix links to implementers' guide (#1865)
  Disabled validators runtime API (#1257)
  Adding `try_state` hook for `Treasury` pallet (#1820)
  ...
@kiltbot kiltbot mentioned this pull request Nov 7, 2023
Closed
@ahmadkaouk ahmadkaouk mentioned this pull request Nov 16, 2023
Closed
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024
@svyatonik
fixed TODOs for weights v2 (paritytech#1860)
11b3a61
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 27, 2024
@svyatonik
fixed TODOs for weights v2 (paritytech#1860)
6abbf65
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik
fixed TODOs for weights v2 (paritytech#1860)
35ce6e6
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
fixed TODOs for weights v2 (paritytech#1860)
95c24a6
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
fixed TODOs for weights v2 (paritytech#1860)
6254c69
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
fixed TODOs for weights v2 (paritytech#1860)
96c6f65
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
@svyatonik @serban300
fixed TODOs for weights v2 (paritytech#1860)
8842730
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
fixed TODOs for weights v2 (paritytech#1860)
9a611f4
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
fixed TODOs for weights v2 (paritytech#1860)
b73aa9b
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
fixed TODOs for weights v2 (paritytech#1860)
be7fe83
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
fixed TODOs for weights v2 (paritytech#1860)
34c5d02
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
fixed TODOs for weights v2 (paritytech#1860)
c9a149d
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
@svyatonik @serban300
fixed TODOs for weights v2 (paritytech#1860)
a3d94f5
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
fixed TODOs for weights v2 (paritytech#1860)
513bd5e
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
@svyatonik @serban300
fixed TODOs for weights v2 (paritytech#1860)
929f9db
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
fixed TODOs for weights v2 (#1860)
a5a3f80
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@liamaharon liamaharon liamaharon approved these changes

@sergejparity sergejparity sergejparity approved these changes

@mateo-moon mateo-moon mateo-moon approved these changes

@altaua altaua Awaiting requested review from altaua

Assignees
No one assigned
Labels
T10-tests This PR/Issue is related to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seadanda @bkchr @liamaharon @sergejparity @mateo-moon