Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap EPM Snapshot, SnapshotMetadata and DesiredTargets to ensure invariants #413

Closed
gpestana opened this issue Apr 27, 2023 · 1 comment · Fixed by #1633
Closed

Wrap EPM Snapshot, SnapshotMetadata and DesiredTargets to ensure invariants #413

gpestana opened this issue Apr 27, 2023 · 1 comment · Fixed by #1633
Assignees
@wirednkod
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@gpestana
Copy link
Contributor

gpestana commented Apr 27, 2023 •
edited
Loading

The Snapshot, SnapshotMetadata and DesiredTargets storage items in the EPM pallet must be kept in sync throughout the election lifetime and be killed in tandem. Currently, these storage items are mutated in different places in the pallet.

It makes sense to refactor EPM to hide those storage items behind a shared wrapper that is used to access/mutate and kill the inner items, so as to make sure the invariants hold true at every point in the election.

(related comment)
@wirednkod
Copy link
Contributor

I would like to work on this @gpestana

@wirednkod wirednkod self-assigned this Apr 27, 2023
@gpestana gpestana mentioned this issue Apr 27, 2023
Merged
@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. and removed C1-low labels Aug 25, 2023
@wirednkod wirednkod added T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed T1-FRAME This PR/Issue is related to core FRAME, the framework. labels Sep 17, 2023
This was referenced Sep 17, 2023
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 22, 2024
@wirednkod @gpestana
@kianenigma @bkchr
Implement wrapping of EPM types (#1633)
3029280 
This PR wraps the `Snapshot`, `SnapshotMetadata` and `DesiredTargets`
storage items in the [EPM
pallet](https://paritytech.github.io/substrate/master/pallet_election_provider_multi_phase/index.html)
in order to keep them in sync throughout the election lifetime and in
order to be killed together.

Prior to this PR, these storage items were mutated in different places
in the pallet;

In addition 2 helper `fns` are introduced for chekcing if all the
wrapped storage items exist or not;

Fixes #413 ;

---------

Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@wirednkod @gpestana
@kianenigma @bkchr
Implement wrapping of EPM types (paritytech#1633)
6b483da 
This PR wraps the `Snapshot`, `SnapshotMetadata` and `DesiredTargets`
storage items in the [EPM
pallet](https://paritytech.github.io/substrate/master/pallet_election_provider_multi_phase/index.html)
in order to keep them in sync throughout the election lifetime and in
order to be killed together.

Prior to this PR, these storage items were mutated in different places
in the pallet;

In addition 2 helper `fns` are introduced for chekcing if all the
wrapped storage items exist or not;

Fixes paritytech#413 ;

---------

Co-authored-by: Gonçalo Pestana <g6pestana@gmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@dependabot-preview @serban300
Bump futures from 0.3.5 to 0.3.6 (paritytech#413)
aa14998
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 8, 2024
@dependabot-preview @serban300
Bump futures from 0.3.5 to 0.3.6 (paritytech#413)
f1e5bdf
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump futures from 0.3.5 to 0.3.6 (paritytech#413)
a759167
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump futures from 0.3.5 to 0.3.6 (paritytech#413)
72692d4
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump futures from 0.3.5 to 0.3.6 (paritytech#413)
6c69447
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump futures from 0.3.5 to 0.3.6 (paritytech#413)
bf6d92c
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump futures from 0.3.5 to 0.3.6 (paritytech#413)
b36d298
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 9, 2024
@dependabot-preview @serban300
Bump futures from 0.3.5 to 0.3.6 (paritytech#413)
e9504cc
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@dependabot-preview @serban300
Bump futures from 0.3.5 to 0.3.6 (paritytech#413)
a96216a
serban300 pushed a commit to serban300/polkadot-sdk that referenced this issue Apr 10, 2024
@dependabot-preview @serban300
Bump futures from 0.3.5 to 0.3.6 (paritytech#413)
86a5470
jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
@dependabot-preview @bkchr
Bump futures from 0.3.5 to 0.3.6 (paritytech#413)
4881622
@github-actions github-actions bot mentioned this issue Jun 5, 2024
Closed
@github-actions github-actions bot mentioned this issue Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wirednkod wirednkod

Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
(Nominated) Proof of Stake
Status: ✅ Done
Security Audit (PRs) - SRLabs
Status: Backlog
Milestone
No milestone
3 participants
@gpestana @wirednkod @the-right-joyce