Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Implements try_state hook in elections and EPM pallets #13979

Merged
merged 7 commits into from
Apr 27, 2023

Conversation

gpestana
Copy link
Contributor

This PR implements the try_state hook in elections and EPM pallets and uses it in the tests. An improvement to this PR would be to work on paritytech/polkadot-sdk#210 to automatically include calling the try_state hook in all tests.

Related to paritytech/polkadot-sdk#239

Replaces #13718

gpestana and others added 2 commits April 23, 2023 17:55
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
@gpestana gpestana added A0-please_review Pull request needs code review. I5-tests Tests need fixing, improving or augmenting. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T0-node This PR/Issue is related to the topic “node”. labels Apr 23, 2023
@gpestana gpestana requested a review from a team April 23, 2023 15:59
@gpestana gpestana self-assigned this Apr 23, 2023
@gpestana
Copy link
Contributor Author

@liamaharon I have addressed your comments from the previous review in #13718 and re-opened this new PR.

@gpestana gpestana requested a review from Ank4n April 24, 2023 07:56
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some potential follow-up or refactoring to be done, but I think it can be left to the author to decided where/how to proceed, so all good for this one.

@gpestana
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for 216bb85

@gpestana
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for 216bb85

@gpestana
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@gpestana
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit de917e9 into master Apr 27, 2023
@paritytech-processbot paritytech-processbot bot deleted the gpestana/try_state_elections_final branch April 27, 2023 18:45
gpestana added a commit that referenced this pull request May 4, 2023
* Adds try_state hook to elections pallets

* Addresses PR review comments

Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>

* remove unecessary println

* ensures try-runtime does not mutate storage

* Addresses PR comments

* Fixes snapshot invariant checks; simplifies test infra

---------

Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
Co-authored-by: parity-processbot <>
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…13979)

* Adds try_state hook to elections pallets

* Addresses PR review comments

Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>

* remove unecessary println

* ensures try-runtime does not mutate storage

* Addresses PR comments

* Fixes snapshot invariant checks; simplifies test infra

---------

Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit I5-tests Tests need fixing, improving or augmenting. T0-node This PR/Issue is related to the topic “node”.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants