This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Implements try_state
hook in elections and EPM pallets
#13979
Merged
paritytech-processbot
merged 7 commits into
master
from
gpestana/try_state_elections_final
Apr 27, 2023
Merged
Implements try_state
hook in elections and EPM pallets
#13979
paritytech-processbot
merged 7 commits into
master
from
gpestana/try_state_elections_final
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
gpestana
added
A0-please_review
Pull request needs code review.
I5-tests
Tests need fixing, improving or augmenting.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
T0-node
This PR/Issue is related to the topic “node”.
labels
Apr 23, 2023
@liamaharon I have addressed your comments from the previous review in #13718 and re-opened this new PR. |
Ank4n
reviewed
Apr 23, 2023
Ank4n
reviewed
Apr 23, 2023
Ank4n
reviewed
Apr 23, 2023
Ank4n
reviewed
Apr 23, 2023
Ank4n
reviewed
Apr 23, 2023
Ank4n
reviewed
Apr 23, 2023
Ank4n
reviewed
Apr 23, 2023
liamaharon
approved these changes
Apr 24, 2023
kianenigma
reviewed
Apr 25, 2023
kianenigma
reviewed
Apr 25, 2023
kianenigma
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some potential follow-up or refactoring to be done, but I think it can be left to the author to decided where/how to proceed, so all good for this one.
Ank4n
approved these changes
Apr 27, 2023
bot merge |
Error: Statuses failed for 216bb85 |
bot merge |
Error: Statuses failed for 216bb85 |
bot rebase |
Rebased |
bot merge |
Waiting for commit status. |
paritytech-processbot
bot
deleted the
gpestana/try_state_elections_final
branch
April 27, 2023 18:45
gpestana
added a commit
that referenced
this pull request
May 4, 2023
* Adds try_state hook to elections pallets * Addresses PR review comments Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> * remove unecessary println * ensures try-runtime does not mutate storage * Addresses PR comments * Fixes snapshot invariant checks; simplifies test infra --------- Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> Co-authored-by: parity-processbot <>
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…13979) * Adds try_state hook to elections pallets * Addresses PR review comments Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> * remove unecessary println * ensures try-runtime does not mutate storage * Addresses PR comments * Fixes snapshot invariant checks; simplifies test infra --------- Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> Co-authored-by: parity-processbot <>
62 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
I5-tests
Tests need fixing, improving or augmenting.
T0-node
This PR/Issue is related to the topic “node”.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
try_state
hook in elections and EPM pallets and uses it in the tests. An improvement to this PR would be to work on paritytech/polkadot-sdk#210 to automatically include calling thetry_state
hook in all tests.Related to paritytech/polkadot-sdk#239
Replaces #13718