Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State Trie Migration #4174

Open
8 of 13 tasks
ggwpez opened this issue Apr 17, 2024 · 6 comments
Open
8 of 13 tasks

State Trie Migration #4174

ggwpez opened this issue Apr 17, 2024 · 6 comments

Comments

@ggwpez
Copy link
Member

ggwpez commented Apr 17, 2024

Need to track where we are and what is missing cc @cheme @PierreBesson.
Three check marks: migration deployed, RPC reports done, migration removed from the runtime.

  • Rococo [x], [x], [ ]
    • Asset-Hub [x], [x], [ ]
    • Bridge-Hub [ ], [ ], [ ], [ ]
    • Contracts [ ], [ ], [ ], [ ]
    • Coretime [ ], [ ], [ ], [ ]
    • People [ ], [ ], [ ], [ ]
  • Westend [x], [x], [ ]
    • Asset-Hub [x], [ ], [ ]
    • Bridge-Hub [ ], [ ], [ ], [ ]
    • Collectives [x], [ ], [ ]
    • Coretime [ ], [ ], [ ], [ ]
    • Glutton [ ], [ ], [ ], [ ]
    • People [ ], [ ], [ ], [ ]
@ggwpez
Copy link
Member Author

ggwpez commented Apr 17, 2024

@cheme i checked all the runtimes and i think i got all the missing ones listed here.
Could you please add the migration to the missing ones? Seems like most new chains have V1 since genesis, so its not that many.

@cheme
Copy link
Contributor

cheme commented Apr 17, 2024

Thanks,

Could you please add the migration to the missing ones?

Will do tomorrow (most likely will be the same change as the one you adapt in cecb8f4 , but I will reread the pallet logic first , just in case.

Seems like most new chains have V1 since genesis, so its not that many.

yes new chain should have started v1 (I am a bit surprise by asset_hub (we migrate at least two statemine/statemint envt), but it can be done any number of time anyway).

Did quickly check and see same thing.
Note that the three first check marks make sense to me, but not the fourth one: the state_version is switch in the runtime at the same time as the runtime with the migration is deployed (the migration only works if the state_version is 1 in the runtime).

@ggwpez
Copy link
Member Author

ggwpez commented Apr 17, 2024

Did quickly check and see same thing.
Note that the three first check marks make sense to me, but not the fourth one: the state_version is switch in the runtime at the same time as the runtime with the migration is deployed (the migration only works if the state_version is 1 in the runtime).

Okay, will remove 👍

@ggwpez
Copy link
Member Author

ggwpez commented May 7, 2024

Enactment for for AH Westend and Collectives Westend should happen with 1.12 upgrade as it was added in #4185.

@ggwpez
Copy link
Member Author

ggwpez commented May 7, 2024

I think AH Rococo completed and we can remove the pallet, or @cheme? It returns this:

{
  progressTop: Complete
  progressChild: ToStart
  size_: 841,970
  topItems: 2,976
  childItems: 0
}

We dont have a node with RPC enabled, but given that the last Migrated events was 1.5 years back, i think its safe to remove, or?

@cheme
Copy link
Contributor

cheme commented May 7, 2024

yes it was when we did test the migration with Pierre, they are finished.

github-merge-queue bot pushed a commit that referenced this issue May 13, 2024
The state-trie migration is completed on Rococo Asset-Hub as
double-checked
[here](#4174 (comment)).
Undeploying now.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this issue Jun 5, 2024
The state-trie migration is completed on Rococo Asset-Hub as
double-checked
[here](paritytech#4174 (comment)).
Undeploying now.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
liuchengxu pushed a commit to liuchengxu/polkadot-sdk that referenced this issue Jun 19, 2024
The state-trie migration is completed on Rococo Asset-Hub as
double-checked
[here](paritytech#4174 (comment)).
Undeploying now.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
The state-trie migration is completed on Rococo Asset-Hub as
double-checked
[here](paritytech#4174 (comment)).
Undeploying now.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants