Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rococo AH: undeploy trie migration #4414

Merged
merged 4 commits into from
May 13, 2024
Merged

Rococo AH: undeploy trie migration #4414

merged 4 commits into from
May 13, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented May 8, 2024

The state-trie migration is completed on Rococo Asset-Hub as double-checked here.
Undeploying now.

ggwpez added 2 commits May 8, 2024 15:34
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez requested a review from cheme May 8, 2024 13:39
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added the T14-system_parachains This PR/Issue is related to system parachains. label May 8, 2024
Copy link
Contributor

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use :
frame_support::migrations::RemovePallet<StateTrieMigrationName, RocksDbWeight>,
and
pub const StateTrieMigrationName: &'static str = "StateTrieMigration";
as first step (as kusuma https://github.com/polkadot-fellows/runtimes/pull/170/files#diff-efa4caeb17487ecb13d8f5eb7863c3241d84afa2e73fbf25909a2ca89df0f362R1948), but it is just removing two key value from the state.

@ggwpez ggwpez added this pull request to the merge queue May 13, 2024
Merged via the queue into master with commit 805d54d May 13, 2024
150 of 151 checks passed
@ggwpez ggwpez deleted the oty-trie-migration-roc-ah branch May 13, 2024 09:00
ordian added a commit that referenced this pull request May 14, 2024
* master:
  improve MockValidationDataInherentDataProvider to support async backing (#4442)
  Bump `proc-macro-crate` to the latest version (#4409)
  [ci] Run check-runtime-migration in GHA (#4441)
  prospective-parachains rework (#4035)
  [ci] Add forklift to GHA ARC (#4372)
  `CheckWeight` SE: Check for extrinsic length + proof size combined (#4326)
  Add generate and verify logic for `AncestryProof` (#4430)
  Rococo AH: undeploy trie migration (#4414)
  Remove `substrate-frame-cli` (#4403)
  migrations: `take()`should consume read and write operation weight (#4302)
  `remote-externalities`: store block header in snapshot (#4349)
  xcm-emlator: Use `BlockNumberFor` instead of `parachains_common::BlockNumber=u32` (#4434)
  Remove `pallet::getter` usage from authority-discovery pallet (#4091)
  Remove pallet::getter usage from pallet-contracts-mock-network (#4417)
  Add docs to request_core_count (#4423)
ggwpez added a commit that referenced this pull request May 24, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 5, 2024
Follow up on #4414 to clean up the old storage.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
The state-trie migration is completed on Rococo Asset-Hub as
double-checked
[here](paritytech#4174 (comment)).
Undeploying now.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
liuchengxu pushed a commit to liuchengxu/polkadot-sdk that referenced this pull request Jun 19, 2024
The state-trie migration is completed on Rococo Asset-Hub as
double-checked
[here](paritytech#4174 (comment)).
Undeploying now.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
The state-trie migration is completed on Rococo Asset-Hub as
double-checked
[here](paritytech#4174 (comment)).
Undeploying now.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
Follow up on paritytech#4414 to clean up the old storage.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T14-system_parachains This PR/Issue is related to system parachains.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants