Rococo AH: cleanup storage #4444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
the
T14-system_parachains
bkchr
approved these changes
May 13, 2024
|
How about a pub struct DetectDanglingStorage<Exceptions: Get<Vec<u8>>>;
impl OnRuntimeUpgrade for DetectDanglingStorage {
fn on_runtime_upgrade() { noop }
fn post_update() {
// iterate over all keys, match them to pallet storage from metadata
// using the same tools that make `DecodeEntireState`
// detect all keys that have value and
// 1. not part of any pallet
// 2. not part of `Exceptions`
} |
|
Yea ^ that sounds pretty nice. |
acatangiu
approved these changes
Jun 5, 2024
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
Follow up on paritytech#4414 to clean up the old storage. --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #4414 to clean up the old storage.