Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the networkState RPC with the latest networking change #555

Open
tomaka opened this issue May 4, 2020 · 4 comments · Fixed by paritytech/polkadot#5894
Open

Update the networkState RPC with the latest networking change #555

tomaka opened this issue May 4, 2020 · 4 comments · Fixed by paritytech/polkadot#5894
Labels
D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I5-enhancement An additional feature request.

Comments

@tomaka
Copy link
Contributor

tomaka commented May 4, 2020

First of all, we can now have multiple active connections to the same node, so the RPC query should be updated to show multiple addresses when that happens.

Additionally, we should also add a lot of things to this query: the list of notification streams open, the ongoing requests, and so on.
Tackling this issue consists in figuring out exactly what can be added, knowing that the point of this query is to show to humans what the current networking state is.

@bkchr
Copy link
Member

bkchr commented May 4, 2020

Wasn't the idea to deprecate this RPC endpoint? Or was this a different one?

@tomaka
Copy link
Contributor Author

tomaka commented May 4, 2020

Yeah, rename it: #558

Gav mentioned that he was looking at it from time to time, and it might indeed not be a bad idea to leave an RPC query for people to look at what their node is doing (as long as we're pretty clear on the fact that what is returned is unstable).

@stale
Copy link

stale bot commented Jul 7, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale label Jul 7, 2021
@tomaka
Copy link
Contributor Author

tomaka commented Jul 8, 2021

Issue still relevant and important.

@stale stale bot removed the A5-stale label Jul 8, 2021
@altonen altonen transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I5-enhancement An additional feature request. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. and removed J0-enhancement labels Aug 25, 2023
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I5-enhancement An additional feature request.
Projects
Status: Backlog 🗒
Development

Successfully merging a pull request may close this issue.

4 participants