Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternatives to the system_networkState RPC query #558

Open
2 tasks done
tomaka opened this issue Apr 6, 2020 · 3 comments
Open
2 tasks done

Add alternatives to the system_networkState RPC query #558

tomaka opened this issue Apr 6, 2020 · 3 comments

Comments

@tomaka
Copy link
Contributor

tomaka commented Apr 6, 2020

It's always been in a kind-of-deprecated-not-supposed-to-be-stable state.
With the new version of libp2p, its output doesn't necessarily make sense anymore (nodes can be connected multiple times), and we would need to change it. Maybe now is the right time to remove this method.

However we first need to add replacements for:

  • Getting the local PeerId.
  • Getting the local listened multiaddresses.
  • more?
@mxinden
Copy link

mxinden commented Apr 6, 2020

I mentioned in Riot that some Prometheus exporters may use this endpoint. I checked the dot exporter and the substrate telemetry exporter which are all the ones I am aware of. None of them seem to be using the endpoint.

@fgimenez
Copy link

fgimenez commented Apr 6, 2020

We use it in polkadot-secure-validator for getting the peer ids and setting up sentries and validator's multiaddresses, is it possible to get this information elsewhere?

This is the relevant part of the code https://github.com/w3f/polkadot-secure-validator/blob/master/ansible/roles/polkadot-common/tasks/main.yml#L70-L84

@tomaka
Copy link
Contributor Author

tomaka commented Apr 7, 2020

Update: since the RPC query shows up in polkadot-js people have been using it to get a broad overview.

Considering how unstable it is, I'd still be in favour of renaming this RPC to something else and adding alternatives so that it doesn't get used by scripts.

@tomaka tomaka changed the title Remove the system_networkState RPC query Add alternatives to the system_networkState RPC query Apr 9, 2020
@altonen altonen transferred this issue from paritytech/substrate Aug 24, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
bkchr pushed a commit that referenced this issue Apr 10, 2024
* Make sure to verify sender's origin.

* Make sure to use dispatch verification.

* Add tests.

* cargo fmt --all

* Remove superfluous lifetime.

* Move the check to MessageLanVerifier.

* cargo fmt --all

* Fix docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog 🗒
Development

No branches or pull requests

5 participants