-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alternatives to the system_networkState RPC query #558
Comments
I mentioned in Riot that some Prometheus exporters may use this endpoint. I checked the dot exporter and the substrate telemetry exporter which are all the ones I am aware of. None of them seem to be using the endpoint. |
We use it in polkadot-secure-validator for getting the peer ids and setting up sentries and validator's multiaddresses, is it possible to get this information elsewhere? This is the relevant part of the code https://github.com/w3f/polkadot-secure-validator/blob/master/ansible/roles/polkadot-common/tasks/main.yml#L70-L84 |
Update: since the RPC query shows up in polkadot-js people have been using it to get a broad overview. Considering how unstable it is, I'd still be in favour of renaming this RPC to something else and adding alternatives so that it doesn't get used by scripts. |
* Make sure to verify sender's origin. * Make sure to use dispatch verification. * Add tests. * cargo fmt --all * Remove superfluous lifetime. * Move the check to MessageLanVerifier. * cargo fmt --all * Fix docs.
It's always been in a kind-of-deprecated-not-supposed-to-be-stable state.
With the new version of libp2p, its output doesn't necessarily make sense anymore (nodes can be connected multiple times), and we would need to change it. Maybe now is the right time to remove this method.
However we first need to add replacements for:
PeerId
.The text was updated successfully, but these errors were encountered: