-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rococo benchmarks not working for polkadot_runtime_parachains::paras_inherent
#5680
Comments
this is working: ab2a78d |
8 tasks
Alternatively, we could patch polkadot-sdk to return 1 here |
@ordian I tried it, but actually it does not work with
|
Merged
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 16, 2024
the range should always contain at least 2 values for the benchmark to work closes #5680
ordian
added a commit
that referenced
this issue
Sep 16, 2024
the range should always contain at least 2 values for the benchmark to work closes #5680
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 22, 2024
It is a first step for switching to the `frame-omni-bencher` for CI. This PR includes several changes related to generating chain specs plus: - [x] pallet `assigned_slots` fix missing `#[serde(skip)]` for phantom - [x] pallet `paras_inherent` benchmark fix - cherry-picked from #5688 - [x] migrates `get_preset` to the relevant runtimes - [x] fixes Rococo genesis presets - does not work https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7317249 - [x] fixes Rococo benchmarks for CI - [x] migrate westend genesis - [x] remove wococo stuff Closes: #5680 ## Follow-ups - Fix for frame-omni-bencher #5655 - Enable new short-benchmarking CI - #5706 - Remove gitlab pipelines for short benchmarking - refactor all Cumulus runtimes to use `get_preset` - #5704 - #5705 - #5700 - [ ] Backport to the stable --------- Co-authored-by: command-bot <> Co-authored-by: ordian <noreply@reusable.software>
bkontur
added a commit
that referenced
this issue
Sep 22, 2024
It is a first step for switching to the `frame-omni-bencher` for CI. This PR includes several changes related to generating chain specs plus: - [x] pallet `assigned_slots` fix missing `#[serde(skip)]` for phantom - [x] pallet `paras_inherent` benchmark fix - cherry-picked from #5688 - [x] migrates `get_preset` to the relevant runtimes - [x] fixes Rococo genesis presets - does not work https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7317249 - [x] fixes Rococo benchmarks for CI - [x] migrate westend genesis - [x] remove wococo stuff Closes: #5680 - Fix for frame-omni-bencher #5655 - Enable new short-benchmarking CI - #5706 - Remove gitlab pipelines for short benchmarking - refactor all Cumulus runtimes to use `get_preset` - #5704 - #5705 - #5700 - [ ] Backport to the stable --------- Co-authored-by: command-bot <> Co-authored-by: ordian <noreply@reusable.software> (cherry picked from commit 8735c66)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(I know Rococo will retire soon, but I would better fix this before we switch to frame-omni-bencher: #5327)
So, because of
max_validators_per_core: Some(1),
https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/runtime/rococo/src/genesis_config_presets.rs#L211:the benchmark enter_backed_candidates_variable generates value for
v
like[(v, 2, 1)]
, which causes error here, e.g. this CI job: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7317555:it is possible to simulate locally in the branch: #5327 with:
How can/should we fix the roococo development genesis config for SchedulerParams/HostConfiguration to pass?
The text was updated successfully, but these errors were encountered: