Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor polkadot-parachain-bin chain-specs for cumulus runtimes and move genesis presets to the runtimes get_preset #5704

Open
2 tasks
bkontur opened this issue Sep 13, 2024 · 1 comment
Open
2 tasks

Refactor polkadot-parachain-bin chain-specs for cumulus runtimes and move genesis presets to the runtimes get_preset #5704

bkontur opened this issue Sep 13, 2024 · 1 comment
Assignees
@iulianbarbu
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. T9-cumulus This PR/Issue is related to cumulus.

Comments

@bkontur
Copy link
Contributor

bkontur commented Sep 13, 2024 •
edited
Loading

Based on: #5327

Few runtimes are missing in the base PR

  • people
  • coretime
  • glutton
  • kitchensink

Tasks
Beta Give feedback
@bkontur bkontur added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T9-cumulus This PR/Issue is related to cumulus. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Sep 13, 2024
@bkontur bkontur mentioned this issue Sep 13, 2024
Merged
8 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 22, 2024
@bkontur @ordian
Moved presets to the testnet runtimes (#5327)
8735c66 
It is a first step for switching to the `frame-omni-bencher` for CI.

This PR includes several changes related to generating chain specs plus:

- [x] pallet `assigned_slots` fix missing `#[serde(skip)]` for phantom
- [x] pallet `paras_inherent` benchmark fix - cherry-picked from
#5688
- [x] migrates `get_preset` to the relevant runtimes
- [x] fixes Rococo genesis presets - does not work
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7317249
- [x] fixes Rococo benchmarks for CI 
- [x] migrate westend genesis
- [x] remove wococo stuff

Closes: #5680

## Follow-ups
- Fix for frame-omni-bencher
#5655
- Enable new short-benchmarking CI -
#5706
- Remove gitlab pipelines for short benchmarking
- refactor all Cumulus runtimes to use `get_preset` -
#5704
- #5705
- #5700
- [ ] Backport to the stable

---------

Co-authored-by: command-bot <>
Co-authored-by: ordian <noreply@reusable.software>
bkontur added a commit that referenced this issue Sep 22, 2024
@bkontur
Moved presets to the testnet runtimes (#5327)
59dfea3 
It is a first step for switching to the `frame-omni-bencher` for CI.

This PR includes several changes related to generating chain specs plus:

- [x] pallet `assigned_slots` fix missing `#[serde(skip)]` for phantom
- [x] pallet `paras_inherent` benchmark fix - cherry-picked from
#5688
- [x] migrates `get_preset` to the relevant runtimes
- [x] fixes Rococo genesis presets - does not work
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7317249
- [x] fixes Rococo benchmarks for CI
- [x] migrate westend genesis
- [x] remove wococo stuff

Closes: #5680

- Fix for frame-omni-bencher
#5655
- Enable new short-benchmarking CI -
#5706
- Remove gitlab pipelines for short benchmarking
- refactor all Cumulus runtimes to use `get_preset` -
#5704
- #5705
- #5700
- [ ] Backport to the stable

---------

Co-authored-by: command-bot <>
Co-authored-by: ordian <noreply@reusable.software>
(cherry picked from commit 8735c66)
@bkontur bkontur mentioned this issue Sep 22, 2024
Closed
This was referenced Sep 30, 2024
Merged
Closed
@iulianbarbu iulianbarbu self-assigned this Sep 30, 2024
@iulianbarbu
Copy link
Contributor

Sounds like an omni node related issue, added it to the project. @kianenigma lmk if you have other thoughts.

@ggwpez ggwpez mentioned this issue Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iulianbarbu iulianbarbu

Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. T9-cumulus This PR/Issue is related to cumulus.
Projects
Polkadot Omni Node
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable GHA short benchmarks with frame-omni-bencher paritytech/polkadot-sdk
2 participants
@bkontur @iulianbarbu