-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bot bench: Allow passing feature flags #5714
Comments
Not a problem to add, though we're going to deprecate this command bot along with old benchmarks, now we have the other command bot built as GHA, and it uses frame-omni-bencher. |
Yeah we need the rve toolchain and a way to set the feature flag in the omni bencher and we should be good. Thanks! |
Just always enabling the |
Is there any progress on this? Sorry don't want to be pushy but we can't really run benchmarks without this. |
@athei sorry for delay, will be done today 👌 |
pallet-revive
requires theriscv
feature for benchmarks. We don't want to add it toruntime-benchmarks
as that will require everybody else to have the rve toolchain installed. So we'd need a way to pass flags to the bot, however this doesn't seem to be supported currently? I imagine something like this should work: #5675 (comment)The text was updated successfully, but these errors were encountered: