Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot bench: Allow passing feature flags #5714

Closed
xermicus opened this issue Sep 13, 2024 · 5 comments · Fixed by #5828
Closed

bot bench: Allow passing feature flags #5714

xermicus opened this issue Sep 13, 2024 · 5 comments · Fixed by #5828
Assignees

Comments

@xermicus
Copy link
Member

pallet-revive requires the riscv feature for benchmarks. We don't want to add it to runtime-benchmarks as that will require everybody else to have the rve toolchain installed. So we'd need a way to pass flags to the bot, however this doesn't seem to be supported currently? I imagine something like this should work: #5675 (comment)

@mordamax
Copy link
Contributor

Not a problem to add, though we're going to deprecate this command bot along with old benchmarks, now we have the other command bot built as GHA, and it uses frame-omni-bencher.
I suspect this still will require riscv feature to be added in your case?

@xermicus
Copy link
Member Author

Yeah we need the rve toolchain and a way to set the feature flag in the omni bencher and we should be good. Thanks!

@mordamax mordamax transferred this issue from paritytech/command-bot Sep 13, 2024
@mordamax mordamax self-assigned this Sep 13, 2024
@athei
Copy link
Member

athei commented Sep 16, 2024

Just always enabling the riscv feature when benchmarking is good enough. That should be easier to implement than adding another command to parse. Both would work for us.

@athei
Copy link
Member

athei commented Sep 23, 2024

Is there any progress on this? Sorry don't want to be pushy but we can't really run benchmarks without this.

@mordamax
Copy link
Contributor

@athei sorry for delay, will be done today 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants