Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add riscv feature to /cmd bench by default #5828

Merged
merged 3 commits into from
Sep 26, 2024
Merged

add riscv feature to /cmd bench by default #5828

merged 3 commits into from
Sep 26, 2024

Conversation

mordamax
Copy link
Contributor

Closes #5714

@mordamax mordamax requested review from a team as code owners September 25, 2024 08:04
@mordamax mordamax added the R0-silent Changes should not be mentioned in any release notes label Sep 25, 2024
athei
athei reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it seems that it would be way better to just allow passing through additional feature flags. Not every runtime or node will have this feature.

.github/scripts/cmd/test_cmd.py Outdated Show resolved Hide resolved
.github/scripts/cmd/cmd.py Outdated Show resolved Hide resolved
athei
athei approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since it only adds the feature to the kitchensink runtime

@mordamax mordamax added this pull request to the merge queue Sep 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2024
@alvicsam alvicsam added this pull request to the merge queue Sep 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2024
@alvicsam alvicsam added this pull request to the merge queue Sep 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2024
@alvicsam alvicsam added this pull request to the merge queue Sep 26, 2024
Merged via the queue into master with commit f6d08e6 Sep 26, 2024
219 checks passed
@alvicsam alvicsam deleted the mak-5714-add-riscv-feature branch September 26, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvicsam alvicsam alvicsam approved these changes

@athei athei athei approved these changes

@xermicus xermicus Awaiting requested review from xermicus

@ggwpez ggwpez Awaiting requested review from ggwpez

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bot bench: Allow passing feature flags
3 participants
@mordamax @athei @alvicsam