Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test for DB upgrades #851

Open
dvdplm opened this issue Mar 21, 2022 · 8 comments
Open

Integration test for DB upgrades #851

dvdplm opened this issue Mar 21, 2022 · 8 comments
Labels
T10-tests This PR/Issue is related to tests.

Comments

@dvdplm
Copy link
Contributor

dvdplm commented Mar 21, 2022

In the light of paritytech/polkadot#5168 it would be good to have zombienet tests in place to test DB version upgrades for both rocksdb and paritydb.

@cheme
Copy link
Contributor

cheme commented Mar 31, 2022

cc @pepoviola

@pepoviola
Copy link
Contributor

Hi @cheme, we can use this config to test a network of two validators, with one validator using paritydb.

[settings]
timeout = 1000
bootnode = false

[relaychain]
default_image = "{{ZOMBIENET_INTEGRATION_TEST_IMAGE}}"
chain = "rococo-local"

  [[relaychain.nodes]]
  name = "alice"
  args = [ "-lparachain=debug", "--database=paritydb-experimental" ]

  [[relaychain.nodes]]
  name = "bob"
  args = [ "-lparachain=debug" ]


[[parachains]]
id = 100
addToGenesis = false

  [[parachains.collator_groups]]
    count = 1
    [parachains.collator_groups.collator]
    name = "collator"
    command = "adder-collator"
    image = "{{COL_IMAGE}}"

And we can test that both nodes are up and other metric that you need.

Thanks!

@sandreim
Copy link
Contributor

@pepoviola we have a paritydb test in our suite right now. I think we just need support to use restard a node with a different image tag in the same test. Are you tracking this feature in Zombienet ?

@pepoviola
Copy link
Contributor

Hi @sandreim, restarting the node with a diff image tag isn't supported because we don't use any kind of persistence disk for the pods. But we can download the new binary and restart the process (in the same pod) using this new version. I created a PoC in this pr. Let me know what you think.

Thanks!

@sandreim
Copy link
Contributor

I don't think we need to persist the data, just changing the binary should be sufficient.

@sandreim
Copy link
Contributor

sandreim commented Aug 16, 2022

Looks like a good idea to look at this as well paritytech/polkadot#5367 . Sounds like something we could test implicitly based on network config, only that we need more assertions.

@pepoviola
Copy link
Contributor

ping @cheme/ @dvdplm this should be covered by paritytech/polkadot#5970
Thanks!

@Sophia-Gold Sophia-Gold transferred this issue from paritytech/polkadot Aug 24, 2023
@pepoviola
Copy link
Contributor

Hi @sandreim, I think this was covered by paritytech/polkadot#5970. Do you think we need to add more test cases or we can close this one?
Thx!

@the-right-joyce the-right-joyce added T10-tests This PR/Issue is related to tests. and removed I5-tests labels Aug 25, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
Co-authored-by: David Dunn <26876072+doubledup@users.noreply.github.com>
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
* Call post_dispatch for CheckedSignature::SelfContained

* add tests

* rename tests

Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T10-tests This PR/Issue is related to tests.
Projects
None yet
Development

No branches or pull requests

6 participants