add test for upgrade polkadot version in node #269
Conversation
pepoviola
changed the title
| @@ -106,7 +106,15 @@ function make_transfer_containter(): any { | |||
| command: [ | |||
| "ash", | |||
| "-c", | |||
| `until [ -f ${FINISH_MAGIC_FILE} ]; do echo waiting for tar to finish; sleep 1; done; echo copy files has finished`, | |||
| [ "wget https://github.com/moparisthebest/static-curl/releases/download/v7.83.1/curl-amd64 -O /cfg/curl", | |||
There was a problem hiding this comment.
Why do you bother downloading curl when you have wget already ?
There was a problem hiding this comment.
Hi @chevdor, this is an init container since the polkadot image don't have wget or curl and the image run as non-root user I make curl (downloading the static version) available through init containers.
|
cc @EgorPopelyaev: this is something we were missing. |
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
|
Thanks @pepoviola . This looks heading to the right direction, but the actual test should live in the polkadot repo under the misc folder. Additionally, it should be able to determine the last release version and start with that, then after doing some work and populating the DB it should switch the client binary to the one from the PR artifacts. Testing both rocksDB and parityDB at same time (2 nodes) would be awesome. |
Hi @sandreim, sounds good. We can start the nodes with the image from Thanks! |
|
anything blocking this? |
No, the feature is already working in zombienet. I can write a test in polkadot repo, did you have a list changes to make in the Thanks! |
|
@pepoviola i think just letting it run for 2-3 sessions with 2 paras should populate the db enough for a PR CI test. @ordian do you think this is enough? |
We discussed the test scenario in DMs. But I think we don't need to wait for 2-3 sessions for this, just produce and import a few blocks. The main point to test if we can open the db from the new version to check if there any breaking changes to the db layout. |
|
So, no reason to go deeper than the layout?, I was thinking it is worth to also catch breaking changes at the content level - decoding a value fails. |
I don't think we need to go for more than a few blocks (+ maybe a dispute) to catch this. |
POC: Add upgrade node test. (see paritytech/polkadot-sdk#851)
cc @chevdor, this is something like we talk last time?
Thanks!