Rename squatted crates #1241
Merged
Rename squatted crates #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morganamilo
added
T8-polkadot
ordian
approved these changes
Aug 29, 2023
ggwpez
approved these changes
Aug 29, 2023
|
The CI pipeline was cancelled due to failure one of the required jobs. |
gilescope
approved these changes
Aug 29, 2023
This commit adds the staging- prefix to squatted crates so we can go forward and publish them to crates.io. Using the staging- prefix is a temp fix until we decide on replacement names. https://forum.parity.io/t/renaming-squated-crates-in-substrate-polkadot-cumulus/1964/6
Morganamilo
force-pushed
the
morganamilo/squat
branch
from
c9d3a21 to
e0f0c6f
Compare
Semi-temporary. We discussed it in the XCM channel, and it is best effort until either 1.) there is an actual renaming of XCM, 2.) we found a better crate naming scheme to circumvent the squatting or 3.) crates-io actually returns us the crates… |
|
sadly 3 is never going to happen due to crate.io policy. |
chevdor
suggested changes
Aug 29, 2023
It took very long to even arrive at this compromise, so i dont think it is worth of changing it again now. The name was settled on in the XCM chat, please ask there 😄 (full quote was "i guess we'll need to push forward without the proper naming but keep in mind that we'll likely get at least a few of the real names back soon."). |
|
@ggwpez oh so the name was already defined, ok. |
chevdor
approved these changes
Aug 29, 2023
Untrue, we have contacted the crates.io team before, and we've been assured that there is an upcoming RFC that attempts to change the squatting policy. Aside from that, I don't care what sort of name we settle into, as long as we have a solution that we can deliver now. |
KiChjang
approved these changes
Aug 29, 2023
|
I wasn't aware of that. That's good news as their current policy is quite annoying. |
acatangiu
approved these changes
Aug 30, 2023
Merged
Daanvdplas
pushed a commit
that referenced
this pull request
Sep 11, 2023
* Rename squatted crates This commit adds the staging- prefix to squatted crates so we can go forward and publish them to crates.io. Using the staging- prefix is a temp fix until we decide on replacement names. https://forum.parity.io/t/renaming-squated-crates-in-substrate-polkadot-cumulus/1964/6 * Fix test after crate renames * Update Lockfile
liamaharon
added a commit
that referenced
this pull request
Oct 2, 2023
…o CI (#1344) Makes SPs first class citizens along with the relay chains in the context of our CI runtime upgrade checks. ## Code changes - Sets missing current storage version in `uniques` pallet - Adds multisig V1 migration to run where it was missing - Removes executed migration whos pre/post hooks were failing from collectives runtime - Initializes storage versions for SP pallets added after genesis - Originally I was going to wait for #1297 to be merged so this wouldn't need to be done manually, but it doesn't seem like it'll be merged any time soon so I've decided to set them manually to unblock this ## CI changes - Removed dependency of `westend` runtime upgrades being complete prior to other ones running. I assume it is supposed to cache the `try-runtime` build for a performance benefit, but it seems it wasn't working. Maybe someone from the CI team can look into this or explain why it needs to be there? - Adds check-runtime-migration jobs for Parity asset-hubs, bridge-hubs and contract chains - Updated VARIABLES to accomodate the `kusama-runtime` package being renamed to `staging-kusama-runtime` in #1241 - Added `EXTRA_ARGS` variable to `check-runtime-migration`, and set `--no-weight-warnings` to the relay chain runtime upgrade checks (relay chains don't have weight restrictions).
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
…o CI (paritytech#1344) Makes SPs first class citizens along with the relay chains in the context of our CI runtime upgrade checks. ## Code changes - Sets missing current storage version in `uniques` pallet - Adds multisig V1 migration to run where it was missing - Removes executed migration whos pre/post hooks were failing from collectives runtime - Initializes storage versions for SP pallets added after genesis - Originally I was going to wait for paritytech#1297 to be merged so this wouldn't need to be done manually, but it doesn't seem like it'll be merged any time soon so I've decided to set them manually to unblock this ## CI changes - Removed dependency of `westend` runtime upgrades being complete prior to other ones running. I assume it is supposed to cache the `try-runtime` build for a performance benefit, but it seems it wasn't working. Maybe someone from the CI team can look into this or explain why it needs to be there? - Adds check-runtime-migration jobs for Parity asset-hubs, bridge-hubs and contract chains - Updated VARIABLES to accomodate the `kusama-runtime` package being renamed to `staging-kusama-runtime` in paritytech#1241 - Added `EXTRA_ARGS` variable to `check-runtime-migration`, and set `--no-weight-warnings` to the relay chain runtime upgrade checks (relay chains don't have weight restrictions).
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
#1241) * update Rococo version + create relayers fund account * start finality relay guards when complex relay is started
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the staging- prefix to squatted crates so we can go forward and publish them to crates.io.
Using the staging- prefix is a temp fix until we decide on replacement names. https://forum.parity.io/t/renaming-squated-crates-in-substrate-polkadot-cumulus/1964/6