Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init System Parachain storage versions and add migration check jobs to CI #1344

Merged
merged 46 commits into from
Oct 2, 2023
Merged

Init System Parachain storage versions and add migration check jobs to CI #1344

merged 46 commits into from
Oct 2, 2023

Conversation

liamaharon
Copy link
Contributor

@liamaharon liamaharon commented Aug 31, 2023 •
edited
Loading

Makes SPs first class citizens along with the relay chains in the context of our CI runtime upgrade checks.

Code changes

  • Sets missing current storage version in uniques pallet
  • Adds multisig V1 migration to run where it was missing
  • Removes executed migration whos pre/post hooks were failing from collectives runtime
  • Initializes storage versions for SP pallets added after genesis

CI changes

  • Removed dependency of westend runtime upgrades being complete prior to other ones running. I assume it is supposed to cache the try-runtime build for a performance benefit, but it seems it wasn't working. Maybe someone from the CI team can look into this or explain why it needs to be there?

  • Adds check-runtime-migration jobs for Parity asset-hubs, bridge-hubs and contract chains

  • Updated VARIABLES to accomodate the kusama-runtime package being renamed to staging-kusama-runtime in Rename squatted crates #1241

  • Added EXTRA_ARGS variable to check-runtime-migration, and set --no-weight-warnings to the relay chain runtime upgrade checks (relay chains don't have weight restrictions).

@paritytech-ci paritytech-ci requested review from a team August 31, 2023 23:07
@liamaharon liamaharon changed the title [dnm] testing check-runtime-migration polkadot and kusama [dnm] fix check-runtime-migration polkadot and kusama Sep 1, 2023
@liamaharon liamaharon changed the title [dnm] fix check-runtime-migration polkadot and kusama [dnm/testing ci] fix check-runtime-migration polkadot and kusama Sep 1, 2023
@liamaharon liamaharon changed the title [dnm/testing ci] fix check-runtime-migration polkadot and kusama [dnm/testing ci] fix system parachain storage versions and add check jobs to CI Sep 1, 2023
@liamaharon liamaharon marked this pull request as draft September 5, 2023 02:36
@liamaharon liamaharon mentioned this pull request Sep 12, 2023
Merged
@liamaharon liamaharon changed the title [dnm/testing ci] fix system parachain storage versions and add check jobs to CI fix system parachain storage versions and add check jobs to CI Sep 14, 2023
@liamaharon liamaharon changed the title fix system parachain storage versions and add check jobs to CI Fix System Parachain storage versions and add migration check jobs to CI Sep 14, 2023
@liamaharon liamaharon added T1-FRAME This PR/Issue is related to core FRAME, the framework. T14-system_parachains This PR/Issue is related to system parachains. labels Sep 14, 2023
@liamaharon liamaharon changed the title Fix System Parachain storage versions and add migration check jobs to CI Initialize System Parachain storage versions and add migration check jobs to CI Sep 14, 2023
@liamaharon liamaharon mentioned this pull request Sep 28, 2023
Merged
@paritytech-ci paritytech-ci requested a review from a team September 29, 2023 14:31
@liamaharon liamaharon dismissed alvicsam’s stale review September 29, 2023 16:54

concern addressed

@liamaharon
Copy link
Contributor Author

bot merge

@command-bot
Copy link

command-bot bot commented Oct 2, 2023

@liamaharon bot merge and bot rebase are not supported anymore. Please use native Github "Auto-Merge" and "Update Branch" buttons instead.
image

@liamaharon liamaharon merged commit db3fd68 into master Oct 2, 2023
11 of 12 checks passed
@liamaharon liamaharon deleted the liam/ci-polkadot-kusama-runtime-migration branch October 2, 2023 15:11
ordian added a commit that referenced this pull request Oct 3, 2023
@ordian
Merge branch 'master' into tsv-disabling-node-side
a3bcb2f 
* master: (24 commits)
  Init System Parachain storage versions and add migration check jobs to CI (#1344)
  no-bound derives: Use absolute path for `core` (#1763)
  migrate alliance, fast-unstake and bags list to use derive-impl (#1636)
  Tvl pool staking (#1322)
  improve service error (#1734)
  frame-support: `RuntimeDebug\Eq\PartialEq` impls for `Imbalance` (#1717)
  Point documentation links to monorepo (#1741)
  [NPoS] Fix for Reward Deficit in the pool (#1255)
  Move import queue from `ChainSync` to `SyncingEngine` (#1736)
  Enable mocking contracts (#1331)
  Revert "fix(review-bot): pull secrets from `master` environment" (#1748)
  Remove kusama and polkadot runtime crates (#1731)
  Use `Extensions` to register offchain worker custom extensions (#1719)
  [RPC-Spec-V2] chainHead: use integer for block index and adjust RuntimeVersion JSON format (#1666)
  fix(review-bot): pull secrets from `master` environment (#1745)
  Fix `subkey inspect` output text padding (#1744)
  archive: Implement height, hashByHeight and call (#1582)
  rpc/client: Propagate `rpc_methods` method to reported methods (#1713)
  rococo-runtime: `RococoGenesisExt` removed (#1490)
  PVF: more filesystem sandboxing (#1373)
  ...
ordian added a commit that referenced this pull request Oct 10, 2023
@ordian
Merge branch 'tsv-disabling-node-side' into tsv-disabling-backing
863fc7d 
* tsv-disabling-node-side: (24 commits)
  Init System Parachain storage versions and add migration check jobs to CI (#1344)
  no-bound derives: Use absolute path for `core` (#1763)
  migrate alliance, fast-unstake and bags list to use derive-impl (#1636)
  Tvl pool staking (#1322)
  improve service error (#1734)
  frame-support: `RuntimeDebug\Eq\PartialEq` impls for `Imbalance` (#1717)
  Point documentation links to monorepo (#1741)
  [NPoS] Fix for Reward Deficit in the pool (#1255)
  Move import queue from `ChainSync` to `SyncingEngine` (#1736)
  Enable mocking contracts (#1331)
  Revert "fix(review-bot): pull secrets from `master` environment" (#1748)
  Remove kusama and polkadot runtime crates (#1731)
  Use `Extensions` to register offchain worker custom extensions (#1719)
  [RPC-Spec-V2] chainHead: use integer for block index and adjust RuntimeVersion JSON format (#1666)
  fix(review-bot): pull secrets from `master` environment (#1745)
  Fix `subkey inspect` output text padding (#1744)
  archive: Implement height, hashByHeight and call (#1582)
  rpc/client: Propagate `rpc_methods` method to reported methods (#1713)
  rococo-runtime: `RococoGenesisExt` removed (#1490)
  PVF: more filesystem sandboxing (#1373)
  ...
@kiltbot kiltbot mentioned this pull request Nov 7, 2023
Closed
@svyatonik svyatonik mentioned this pull request Nov 13, 2023
Merged
5 tasks
@ahmadkaouk ahmadkaouk mentioned this pull request Nov 16, 2023
Closed
fellowship-merge-bot bot pushed a commit to polkadot-fellows/runtimes that referenced this pull request Nov 30, 2023
@svyatonik @bkontur
@muharem @bkchr @joepetrowski @acatangiu
Upgrade from v1.2 to v1.3 (#87)
4e4da08 
Opening PR mostly for visibility - I expect #56 to be finished before,
which would bump everything to v1.2 and then I'll convert this PR to
v1.2 -> v1.3. In its current state, this PR does v1.0 -> v1.3 bump,
although I've only been looking at [v1.2 -> v1.3
changelog](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.3.0),
so everything else just compiles.

TODOs left in this PR (which I'd like to address after #56 is finished):
- [x] revert `[cargo upgrade --pinned
--incompatible](https://github.com/polkadot-fellows/runtimes/commit/8df27a586b598d2f783b53cd62b127b8f8ac846a)`
and only leave sdk crates bump;
- [x] rebase on top of #56;
- [x] ensure that remaining PRs from v1.2 -> v1.3 are either not
required for P/K or shall be added later
(paritytech/polkadot-sdk#1344,
paritytech/polkadot-sdk#1333);
- [x] update weights
- [x] ~(maybe worth a separate PR) there's a lot of unused weight files
in this repo - I'd like to remove it~ will do it in a separate PR -
tracked here:
https://github.com/svyatonik/runtimes/tree/remove-unused-weight-files

@liamaharon Can you, please, confirm that the
paritytech/polkadot-sdk#1344 was necessary only
for sdk CI fixes - that PR caught my eye when I was looking at 1.3
CHANGELOG and I was wondering if we need to do the same for Polkadot,
Kusama and system parachains?

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: muharem <ismailov.m.h@gmail.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@liamaharon
Init System Parachain storage versions and add migration check jobs t…
82665a6 
…o CI (paritytech#1344)

Makes SPs first class citizens along with the relay chains in the
context of our CI runtime upgrade checks.

## Code changes

- Sets missing current storage version in `uniques` pallet
- Adds multisig V1 migration to run where it was missing
- Removes executed migration whos pre/post hooks were failing from
collectives runtime
- Initializes storage versions for SP pallets added after genesis
- Originally I was going to wait for
paritytech#1297 to be merged so
this wouldn't need to be done manually, but it doesn't seem like it'll
be merged any time soon so I've decided to set them manually to unblock
this

## CI changes

- Removed dependency of `westend` runtime upgrades being complete prior
to other ones running. I assume it is supposed to cache the
`try-runtime` build for a performance benefit, but it seems it wasn't
working. Maybe someone from the CI team can look into this or explain
why it needs to be there?

- Adds check-runtime-migration jobs for Parity asset-hubs, bridge-hubs
and contract chains

- Updated VARIABLES to accomodate the `kusama-runtime` package being
renamed to `staging-kusama-runtime` in
paritytech#1241

- Added `EXTRA_ARGS` variable to `check-runtime-migration`, and set
`--no-weight-warnings` to the relay chain runtime upgrade checks (relay
chains don't have weight restrictions).
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
use DecodeLimit when decoding incoming calls (#1344)
814f235
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altaua altaua altaua approved these changes

@sergejparity sergejparity sergejparity approved these changes

@alvicsam alvicsam alvicsam approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

@bkchr bkchr bkchr approved these changes

@jsidorenko jsidorenko Awaiting requested review from jsidorenko

@kianenigma kianenigma Awaiting requested review from kianenigma

@ggwpez ggwpez Awaiting requested review from ggwpez

Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework. T14-system_parachains This PR/Issue is related to system parachains.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@liamaharon @kianenigma @bkchr @ggwpez @joepetrowski @alvicsam @sergejparity @altaua