Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SafeCallFilter from Relay Runtimes #1303

Merged
merged 3 commits into from
Sep 9, 2023
Merged

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Aug 30, 2023

The relays do not care about PoV size, so we dont need a SafeCallFilter here.

The relays do not suffer from PoV bloat, so we dont need a
SafeCallFilter here.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Aug 30, 2023
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez merged commit fbf5a81 into master Sep 9, 2023
6 checks passed
@ggwpez ggwpez deleted the oty-remove-safecall-filter branch September 9, 2023 14:29
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
* Remove SafeCallFilter from relay runtimes

The relays do not suffer from PoV bloat, so we dont need a
SafeCallFilter here.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Clippy

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez added a commit to polkadot-fellows/runtimes that referenced this pull request Jan 30, 2024
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
fellowship-merge-bot bot added a commit to polkadot-fellows/runtimes that referenced this pull request Feb 2, 2024
We imported the runtimes into this repo at tag
[`v1.1.0-rc2`](https://github.com/paritytech/polkadot-sdk/commits/v1.1.0-rc2/)
but still merged stuff until they got removed in
[#1731](paritytech/polkadot-sdk#1731).
This re-applies all changes in that commit range
[`v1.1.0-rc2..bf90cb0b`](paritytech/polkadot-sdk@v1.1.0-rc2...bf90cb0)
checked in the SDK with
`git log v1.1.0-rc2..bf90cb0b -- polkadot/runtime/`. Closes
#112

Most changes got applied as part of
#56, but two were
missing:
- paritytech/polkadot-sdk#1303
- <s>https://github.com/paritytech/polkadot-sdk/pull/1476</s> (reverted)

<s>One [open
Q](#67 (comment))
since there was a difference between
[#1291](paritytech/polkadot-sdk#1291) and
#67.</s>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants