Disable Calls to Identity Pallet #1476

joepetrowski · 2023-09-08T17:28:28Z

This PR filters calls from the Identity pallet from all Relay Chain runtimes as preparation to move the identity state and logic to a system parachain within each network.

After this change is deployed to a runtime, no more changes such as adding new sub-identities will be possible. The frozen state will be part of the genesis state of the system chain. After the system chain launches, the pallet and all state will be removed from each Relay Chain.

Applications and UIs that render display information from this pallet will need to read from the system chain when it launches.

polkadot/runtime/kusama/src/lib.rs

polkadot/runtime/rococo/src/lib.rs

ggwpez

We need to make sure that this is in the changelog. And maybe also ping Jaco.

There is a similar MR over here that is looking for a second review 🙏 #1303

gilescope · 2023-09-09T11:35:48Z

Will this prevent identity calls within a utility.batch or a utility.asDerivative call ? (Ideally we should have a generic base call filter that can walk containers)

joepetrowski · 2023-09-09T11:43:50Z

Will this prevent identity calls within a utility.batch or a utility.asDerivative call ? (Ideally we should have a generic base call filter that can walk containers)

Yes, it does

bkchr · 2023-09-09T20:30:09Z

This pr should be opened against the fellowship runtimes repo.

joepetrowski · 2023-09-10T05:31:37Z

polkadot-fellows/runtimes#25

muharem

was curious what an error a user will see, its going to be CallFiltered - link

KiChjang

Best get this merged ASAP before we have to redo this again in the fellowship repo.

joepetrowski · 2023-09-19T04:32:07Z

Best get this merged ASAP before we have to redo this again in the fellowship repo.

We will still need it in both repos AFAIK because Rococo/Westend will stay here but Polkadot/Kusama will only be synced with the 1.1.0 commit.

xlc · 2023-09-19T04:45:54Z

@joepetrowski could you write something at https://forum.polkadot.network about this? People need to know this feature will be paused for some time. How long do you expect for the down time? And combined with polkadot-fellows/runtimes#31, I want to see a written down plan.

xlc · 2023-09-19T04:47:46Z

And this is going to conflict with #1291 a bit. We need to make sure the fellowship can be a registrar on the new chain as well.

joepetrowski · 2023-09-19T04:48:58Z

And this is going to conflict with #1291 a bit. We need to make sure the fellowship can be a registrar on the new chain as well.

That is not a conflict, it's just a feature request for the new chain. There is nothing about having Identity pallet on a parachain that makes it impossible for Fellowship to do something. The pallet's location in the system is purely architectural.

xlc · 2023-09-19T04:52:26Z

I am not saying this is going to cause problem, but more work will be required. At least my old testing script have to be updated.
In order words, the fellowship as registrar work have to be paused until the new chain is up.

joepetrowski · 2023-09-19T04:54:13Z

@joepetrowski could you write something at https://forum.polkadot.network about this? People need to know this feature will be paused for some time. How long do you expect for the down time? And combined with polkadot-fellows/runtimes#31, I want to see a written down plan.

The PR description is a written plan. Yes I am working on something to share on the forum and in a Fellowship RFC. It should not be too shocking, the goal of system parachains has always been to migrate functionality off the Relay Chain (mentioned way back in 2019).

joepetrowski · 2023-09-19T04:59:06Z

I am not saying this is going to cause problem, but more work will be required. At least my old testing script have to be updated. In order words, the fellowship as registrar work have to be paused until the new chain is up.

Yes, Polkadot is upgradeable and sometimes testing scripts need to be updated. Do you know that the Fellowship wants to act as a registrar? And if so, having Identity on a parachain seems like a perfect way to eat our own dog food and show a cross-parachain application.

Reverts #1476 The `lock_pallet` / `unlock_pallet` additions in #1814 will result in less downtime for users than using runtime upgrades.

Polkadot-Forum · 2023-10-27T17:04:37Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v1-2-0/4451/1

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

This reverts commit fc9da09. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

We imported the runtimes into this repo at tag [`v1.1.0-rc2`](https://github.com/paritytech/polkadot-sdk/commits/v1.1.0-rc2/) but still merged stuff until they got removed in [#1731](paritytech/polkadot-sdk#1731). This re-applies all changes in that commit range [`v1.1.0-rc2..bf90cb0b`](paritytech/polkadot-sdk@v1.1.0-rc2...bf90cb0) checked in the SDK with `git log v1.1.0-rc2..bf90cb0b -- polkadot/runtime/`. Closes #112 Most changes got applied as part of #56, but two were missing: - paritytech/polkadot-sdk#1303 - <s>https://github.com/paritytech/polkadot-sdk/pull/1476</s> (reverted) <s>One [open Q](#67 (comment)) since there was a difference between [#1291](paritytech/polkadot-sdk#1291) and #67.</s> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

joepetrowski added 2 commits September 8, 2023 18:15

disable identity

9950144

more readable with EverythingBut

d12c98d

joepetrowski added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Sep 8, 2023

joepetrowski requested review from gavofyork and kianenigma September 8, 2023 17:28

Merge branch 'master' into joe-disable-identity

cea34c6

KiChjang reviewed Sep 9, 2023

View reviewed changes

polkadot/runtime/kusama/src/lib.rs Outdated Show resolved Hide resolved

ggwpez reviewed Sep 9, 2023

View reviewed changes

polkadot/runtime/rococo/src/lib.rs Outdated Show resolved Hide resolved

ggwpez approved these changes Sep 9, 2023

View reviewed changes

Merge remote-tracking branch 'origin' into joe-disable-identity

abdcf89

correct docs and cleaner match

5fa1dc3

muharem approved these changes Sep 18, 2023

View reviewed changes

merge master

a42001f

joepetrowski requested a review from a team as a code owner September 18, 2023 09:51

KiChjang approved these changes Sep 18, 2023

View reviewed changes

Merge branch 'master' into joe-disable-identity

fb0ce53

joepetrowski merged commit 771c3fb into master Sep 20, 2023
6 checks passed

joepetrowski deleted the joe-disable-identity branch September 20, 2023 05:28

joepetrowski mentioned this pull request Oct 17, 2023

Re-enable Identity on Westend and Rococo #1901

Merged

Tbaut mentioned this pull request Oct 17, 2023

Easy flow to set an identity ChainSafe/Multix#404

Merged

6 tasks

kiltbot mentioned this pull request Oct 19, 2023

[AUTOMATIC] Update Polkadot dependencies from 1.1.0 to 1.2.0 KILTprotocol/kilt-node#571

Closed

joepetrowski added a commit that referenced this pull request Oct 23, 2023

Re-enable Identity on Westend and Rococo (#1901)

9505243

Reverts #1476 The `lock_pallet` / `unlock_pallet` additions in #1814 will result in less downtime for users than using runtime upgrades.

ahmadkaouk mentioned this pull request Nov 16, 2023

Update polkadot-sdk from v.1.1.0 to v1.3.0 moonbeam-foundation/moonbeam#2565

Closed

ggwpez added a commit to polkadot-fellows/runtimes that referenced this pull request Jan 30, 2024

Reapply paritytech/polkadot-sdk#1476

fc9da09

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez mentioned this pull request Jan 30, 2024

Reapply changes since v1.1.0-rc2 import polkadot-fellows/runtimes#172

Merged

ggwpez added a commit to polkadot-fellows/runtimes that referenced this pull request Jan 31, 2024

Revert "Reapply paritytech/polkadot-sdk#1476"

36e16fc

This reverts commit fc9da09. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable Calls to Identity Pallet #1476

Disable Calls to Identity Pallet #1476

joepetrowski commented Sep 8, 2023

ggwpez left a comment •

edited

Loading

gilescope commented Sep 9, 2023

joepetrowski commented Sep 9, 2023

bkchr commented Sep 9, 2023

joepetrowski commented Sep 10, 2023

muharem left a comment

KiChjang left a comment

joepetrowski commented Sep 19, 2023

xlc commented Sep 19, 2023

xlc commented Sep 19, 2023

joepetrowski commented Sep 19, 2023 •

edited

Loading

xlc commented Sep 19, 2023 •

edited

Loading

joepetrowski commented Sep 19, 2023

joepetrowski commented Sep 19, 2023

Polkadot-Forum commented Oct 27, 2023

Disable Calls to Identity Pallet #1476

Disable Calls to Identity Pallet #1476

Conversation

joepetrowski commented Sep 8, 2023

ggwpez left a comment • edited Loading

Choose a reason for hiding this comment

gilescope commented Sep 9, 2023

joepetrowski commented Sep 9, 2023

bkchr commented Sep 9, 2023

joepetrowski commented Sep 10, 2023

muharem left a comment

Choose a reason for hiding this comment

KiChjang left a comment

Choose a reason for hiding this comment

joepetrowski commented Sep 19, 2023

xlc commented Sep 19, 2023

xlc commented Sep 19, 2023

joepetrowski commented Sep 19, 2023 • edited Loading

xlc commented Sep 19, 2023 • edited Loading

joepetrowski commented Sep 19, 2023

joepetrowski commented Sep 19, 2023

Polkadot-Forum commented Oct 27, 2023

ggwpez left a comment •

edited

Loading

joepetrowski commented Sep 19, 2023 •

edited

Loading

xlc commented Sep 19, 2023 •

edited

Loading